laantungir/zapstore
1
0
Fork 0
mirror of https://github.com/zapstore/zapstore.git synced 2026-10-05 20:48:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Hotfix startup crash: defer router sync to avoid modifying provider during build

Browse Source 
GoRouter's delegate notifies listeners during the widget tree build phase.
Since 83a74ceb, syncInstalledPackages() fires on every navigation (including
initial route), modifying state synchronously before its first await.
Wrap in Future.microtask() to defer past the build.
This commit is contained in:
Henrique Velloso
2026-02-06 19:57:44 -03:00
parent 365f2b98c2
commit 817e49f59a
1 changed files with 26 additions and 21 deletions
Download Patch File Download Diff File Expand all files Collapse all files
lib/router.dart
+26 -21
View File
@@ -140,28 +140,33 @@ final routerProvider = Provider<GoRouter>((ref) {
final currentPath = router.routerDelegate.currentConfiguration.uri.path;
final isUpdatesRoute = currentPath.startsWith('/updates');
final wasUpdatesRoute = previousPath?.startsWith('/updates') ?? false;
// Sync installed packages on every navigation to catch sideloads,
// external installs/uninstalls, and self-updating apps.
// This is a local-only platform channel call (~100-500ms, no network).
unawaited(
ref.read(packageManagerProvider.notifier).syncInstalledPackages().then((
_,
) {
// If on updates branch, trigger a recalculation of updates after sync
if (isUpdatesRoute) {
ref.invalidate(categorizedUpdatesProvider);
}
}),
);
// Clear completed operations when navigating AWAY from updates
// This cleans up the "All done" state without affecting the count while visible
if (wasUpdatesRoute && !isUpdatesRoute) {
ref.read(packageManagerProvider.notifier).clearCompletedOperations();
}
previousPath = currentPath;
// Defer provider modifications to the next microtask. GoRouter's delegate
// can notify listeners synchronously during the widget tree build phase
// (e.g. on initial route resolution), and modifying StateNotifier state
// during build triggers a StateNotifierListenerError.
Future.microtask(() {
// Sync installed packages on every navigation to catch sideloads,
// external installs/uninstalls, and self-updating apps.
// This is a local-only platform channel call (~100-500ms, no network).
unawaited(
ref.read(packageManagerProvider.notifier).syncInstalledPackages().then((
_,
) {
// If on updates branch, trigger a recalculation of updates after sync
if (isUpdatesRoute) {
ref.invalidate(categorizedUpdatesProvider);
}
}),
);
// Clear completed operations when navigating AWAY from updates
// This cleans up the "All done" state without affecting the count while visible
if (wasUpdatesRoute && !isUpdatesRoute) {
ref.read(packageManagerProvider.notifier).clearCompletedOperations();
}
});
}
router.routerDelegate.addListener(onRouteChange);