laantungir/super_ball
1
0
Fork 1
Code Issues Pull Requests Packages Projects Releases Wiki Activity

Adds reply and profile creation along with post functionality #1

Closed
npub1wsauh7vr2kwz5kpyk0hwzja35640a9gls5t wants to merge 0 commits from npub1wsauh7vr2kwz5kpyk0hwzja35640a9gls5t/super_ball:master into master
pull from: npub1wsauh7vr2kwz5kpyk0hwzja35640a9gls5t/super_ball:master
merge into: :master
Conversation 3 Commits - Files Changed -
+169 -16
npub1wsauh7vr2kwz5kpyk0hwzja35640a9gls5t commented 2025-11-16 04:38:47 +00:00
First-time contributor
Copy Link
Copy Source

This commit introduces new features to enhance user interaction and profile management:

  • Adds the ability to create replies for comments
  • Enables profile creation for users
  • Supports post creation for sharing updates and content
This commit introduces new features to enhance user interaction and profile management: - Adds the ability to create replies for comments - Enables profile creation for users - Supports post creation for sharing updates and content
npub1wsauh7vr2kwz5kpyk0hwzja35640a9gls5t added 2 commits 2025-11-16 04:38:47 +00:00
Adds reply and profile creation along with post functionality 516c4f2f80 
This commit introduces new features to enhance user interaction and profile management:

- Adds the ability to create replies for comments
- Enables profile creation for users
- Supports post creation for sharing updates and content
CSS c4d73026b5
laantungir commented 2025-11-17 23:21:47 +00:00
Owner
Copy Link
Copy Source

I like the idea, as my intention was always to add more kinds, but code isn't working.

Create Profile should be more fleshed out, and it is writing over users profile instead of creating a new profile.

Reply isn't fully replying to a post. See the below differences :


Reply to a post using Primal

{
    "kind": 1,
    "created_at": 1763420960,
    "content": "From Primal.",
    "pubkey": "8ff74724ed641b3c28e5a86d7c5cbc49c37638ace8c6c38935860e7a5eedde0e",
    "id": "555c77e419c6f34d1d36b6baf36489c5eb17d829645c940fc996d90c26df59a1",
    "tags": [
        [
            "e",
            "ac50dd87901863590d577fb9080ab294b8dd1b6b10563e9733d5bad817c735db",
            "wss://nos.lol",
            "root"
        ],
        [
            "p",
            "8ff74724ed641b3c28e5a86d7c5cbc49c37638ace8c6c38935860e7a5eedde0e"
        ],
        [
            "r",
            "wss://nostr.mom/"
        ],
        [
            "r",
            "wss://relay.laantungir.net/"
        ]
    ],
    "sig": "5ab8f7b43e972e2089ebc95f68c49cace183832a3f867801a85c689ce6797eaa52a60ba07847212019fc2361ffca276c74f9cd69402095c6c783faac2c827bde"
}


Reply to post from proposed superball builder change.

{
    "id": "56e6dadc32afe11f13e83fcf8107ea8a819e4a96232d64eacafd10370224e685",
    "sig": "3766102783acfc7654f134b1dc5fd716e89e154fc81a96c7f60d20a867e5b52919cdfa7a01151550880e4e8a2945ef05feb43c022bbd7761724ded8308254b1d",
    "kind": 1,
    "tags": [
        [
            "e",
            "ac50dd87901863590d577fb9080ab294b8dd1b6b10563e9733d5bad817c735db",
            "root"
        ]
    ],
    "pubkey": "8ff74724ed641b3c28e5a86d7c5cbc49c37638ace8c6c38935860e7a5eedde0e",
    "content": "Yeah, it is a great night.",
    "created_at": 1763420892
}
I like the idea, as my intention was always to add more kinds, but code isn't working. Create Profile should be more fleshed out, and it is writing over users profile instead of creating a new profile. Reply isn't fully replying to a post. See the below differences : ``` Reply to a post using Primal { "kind": 1, "created_at": 1763420960, "content": "From Primal.", "pubkey": "8ff74724ed641b3c28e5a86d7c5cbc49c37638ace8c6c38935860e7a5eedde0e", "id": "555c77e419c6f34d1d36b6baf36489c5eb17d829645c940fc996d90c26df59a1", "tags": [ [ "e", "ac50dd87901863590d577fb9080ab294b8dd1b6b10563e9733d5bad817c735db", "wss://nos.lol", "root" ], [ "p", "8ff74724ed641b3c28e5a86d7c5cbc49c37638ace8c6c38935860e7a5eedde0e" ], [ "r", "wss://nostr.mom/" ], [ "r", "wss://relay.laantungir.net/" ] ], "sig": "5ab8f7b43e972e2089ebc95f68c49cace183832a3f867801a85c689ce6797eaa52a60ba07847212019fc2361ffca276c74f9cd69402095c6c783faac2c827bde" } Reply to post from proposed superball builder change. { "id": "56e6dadc32afe11f13e83fcf8107ea8a819e4a96232d64eacafd10370224e685", "sig": "3766102783acfc7654f134b1dc5fd716e89e154fc81a96c7f60d20a867e5b52919cdfa7a01151550880e4e8a2945ef05feb43c022bbd7761724ded8308254b1d", "kind": 1, "tags": [ [ "e", "ac50dd87901863590d577fb9080ab294b8dd1b6b10563e9733d5bad817c735db", "root" ] ], "pubkey": "8ff74724ed641b3c28e5a86d7c5cbc49c37638ace8c6c38935860e7a5eedde0e", "content": "Yeah, it is a great night.", "created_at": 1763420892 } ```
ciajaf commented 2025-11-18 04:13:24 +00:00
First-time contributor
Copy Link
Copy Source

New PR: https://git.laantungir.net/laantungir/super_ball/pulls/2

I reached out to you on Nostr via Superball's UI. I had fixed it by then but updating the PR wasn't possible because I had used an ephemeral nsec to create that PR.

it is writing over users profile instead of creating a new profile

What do you mean by this? Isn't kind 0 a replaceable event?

New PR: https://git.laantungir.net/laantungir/super_ball/pulls/2 I reached out to you on Nostr via Superball's UI. I had fixed it by then but updating the PR wasn't possible because I had used an ephemeral nsec to create that PR. > it is writing over users profile instead of creating a new profile What do you mean by this? Isn't kind 0 a replaceable event?
laantungir commented 2025-12-01 18:16:20 +00:00
Owner
Copy Link
Copy Source

Moved to new PR.

Moved to new PR.
laantungir closed this pull request 2025-12-01 18:16:20 +00:00

Pull request closed

Please reopen this pull request to perform a merge.
Sign in to join this conversation.
Reviewers
No Reviewers
Labels
No items
No labels
Milestone
No items
No Milestone
Projects
Clear projects
No projects
Assignees
Clear assignees
laantungir (Laan Tungir)
No Assignees
3 Participants
Notifications
Due Date
No due date set.
Dependencies

No dependencies set.

Reference: laantungir/super_ball#1