laantungir/seedsigner
1
0
Fork 0
mirror of https://github.com/SeedSigner/seedsigner.git synced 2026-10-05 15:08:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

Fix CI crash in screenshot generator when latest-release fetch fails

Browse Source 
The screenshot generator fetches the latest release tag at import time via an
unauthenticated GitHub API call. GitHub-hosted runners share outbound IPs and
the unauthenticated api.github.com limit is 60 req/hr/IP, so the call was
intermittently rate-limited (HTTP 403), returned (None, None), and fed None into
the mock_version_to_most_recent_release Version mock. That crashed rendering for
every locale with "TypeError: 'NoneType' object is not subscriptable" in the
OpeningSplash version string (and would likewise hit len(None) on the Version
settings screen).

Substitute a placeholder version name and timestamp when the fetch can't resolve
the latest release, so the "release build" screenshots still render instead of
feeding None into the mock. The real fetch is unchanged when it succeeds.
This commit is contained in:
kdmukai
2026-08-09 18:23:34 -05:00
parent aa1897e8f7
commit a6dfb0cdc0
1 changed files with 10 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
tests/screenshot_generator/generator.py
+10 -2
View File
@@ -7,6 +7,7 @@ import sys
import time
from contextlib import contextmanager
from dataclasses import dataclass
from datetime import datetime
from PIL import ImageFont
from unittest.mock import Mock, patch, MagicMock
@@ -116,10 +117,17 @@ seed_24_w_passphrase = Seed(mnemonic=mnemonic_24, passphrase="some-PASS*phrase9"
MULTISIG_WALLET_DESCRIPTOR = """wsh(sortedmulti(1,[22bde1a9/48h/1h/0h/2h]tpubDFfsBrmpj226ZYiRszYi2qK6iGvh2vkkghfGB2YiRUVY4rqqedHCFEgw12FwDkm7rUoVtq9wLTKc6BN2sxswvQeQgp7m8st4FP8WtP8go76/{0,1}/*,[73c5da0a/48h/1h/0h/2h]tpubDFH9dgzveyD8zTbPUFuLrGmCydNvxehyNdUXKJAQN8x4aZ4j6UZqGfnqFrD4NqyaTVGKbvEW54tsvPTK2UoSbCC1PJY8iCNiwTL3RWZEheQ/{0,1}/*))#3jhtf6yx"""
# Grab the most recent release version info
# Grab the most recent release version info for the "release build" splash screenshots.
(latest_release_version_name, latest_release_version_timestamp) = VersionUtils._fetch_latest_seedsigner_release_tag()
if not latest_release_version_name or not latest_release_version_timestamp:
print("Could not fetch latest release version from GitHub")
# The fetch can fail (offline, or the unauthenticated GitHub API rate-limit that
# shared CI runners regularly hit). Substitute a placeholder so the "release build"
# screenshots still render, rather than feeding None into the Version mock (which
# would otherwise crash both the splash screen and the Version settings screen on
# None slicing / len()).
print("Could not fetch latest release version from GitHub; using a placeholder")
latest_release_version_name = latest_release_version_name or "version_not_available"
latest_release_version_timestamp = latest_release_version_timestamp or datetime(1970, 1, 1)
# Wrap QRDisplayScreen's `render_brightness_tip` in a simple View + Screen so we