laantungir/ngit-grasp
1
0
Fork 0
mirror of https://relay.ngit.dev/npub15qydau2hjma6ngxkl2cyar74wzyjshvl65za5k5rl69264ar2exs5cyejr/ngit-grasp.git synced 2026-10-05 23:18:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

remove dead code: get_authorization_from_db and collect_all_authorized_maintainers

Browse Source 
Both were pub functions with no callers. Clippy doesn't flag dead pub
items because the compiler treats them as potentially used by external
crates - only private items trigger the dead_code lint.
This commit is contained in:
DanConwayDev
2026-02-24 11:39:55 +00:00
parent c31a313ccf
commit aa40780d6f
1 changed files with 0 additions and 74 deletions
Download Patch File Download Diff File Expand all files Collapse all files
src/git/authorization.rs
-74
View File
@@ -410,31 +410,6 @@ fn get_maintainers_recursive(
}
}
/// Collect all authorized maintainers as a flat set from all announcements
///
/// This is a convenience function that flattens the per-owner maintainer lists
/// into a single set. Use this when you don't need owner-specific authorization.
pub fn collect_all_authorized_maintainers(
announcements: &[RepositoryAnnouncement],
) -> HashSet<String> {
let by_owner = collect_authorized_maintainers(announcements);
let mut all_authorized = HashSet::new();
for maintainers in by_owner.values() {
for maintainer in maintainers {
all_authorized.insert(maintainer.clone());
}
}
debug!(
"Collected {} total authorized maintainers from {} owners",
all_authorized.len(),
by_owner.len()
);
all_authorized
}
/// Find the latest state event authored by an authorized maintainer
///
/// Returns the state with the highest created_at timestamp among those
@@ -497,55 +472,6 @@ pub fn is_latest_state(
true
}
/// Get the authorization result for a repository from the database
///
/// This is the main entry point for authorization that queries the database directly.
/// It:
/// 1. Fetches all announcements and states for the identifier with a single query
/// 2. Collects all authorized maintainers from announcements
/// 3. Finds the latest state event from an authorized maintainer
///
/// Returns an `AuthorizationResult` that indicates whether a push is authorized.
pub async fn get_authorization_from_db(
database: &SharedDatabase,
identifier: &str,
) -> Result<AuthorizationResult> {
// Fetch all repository data with a single query
let repo_data = fetch_repository_data_excluding_purgatory(database, identifier).await?;
if repo_data.announcements.is_empty() {
return Ok(AuthorizationResult::denied(
"No repository announcement found",
));
}
// Collect all authorized maintainers (flattened across all owners)
let authorized = collect_all_authorized_maintainers(&repo_data.announcements);
if authorized.is_empty() {
return Ok(AuthorizationResult::denied(
"No authorized maintainers found",
));
}
debug!(
"Found {} authorized maintainers for repository {}",
authorized.len(),
identifier
);
// Find the latest authorized state
match find_latest_authorized_state(&repo_data.states, &authorized) {
Some(state) => Ok(AuthorizationResult::authorized(
state.clone(),
authorized.into_iter().collect(),
)),
None => Ok(AuthorizationResult::denied(
"No state event found from authorized publishers",
)),
}
}
/// Get the authorization result for a repository scoped to a specific owner
///
/// Push authorization checks ONLY purgatory for state events. The database represents