laantungir/ngit-grasp
1
0
Fork 0
mirror of https://relay.ngit.dev/npub15qydau2hjma6ngxkl2cyar74wzyjshvl65za5k5rl69264ar2exs5cyejr/ngit-grasp.git synced 2026-10-06 15:38:25 +00:00
Code Issues Packages Projects Releases Wiki Activity

update issue b454: mark implementation complete

Browse Source
This commit is contained in:
DanConwayDev
2026-01-20 07:43:03 +00:00
parent e14d6c3e67
commit 56c678eb3f
1 changed files with 17 additions and 5 deletions
Download Patch File Download Diff File Expand all files Collapse all files
b454-nixos-module-execstartpre-datadir.md
+17 -5
View File
@@ -15,11 +15,13 @@ Root cause: The NixOS module creates tmpfiles rules for the data directory, but
## Plan
- [ ] Phase 1: Add `ExecStartPre` to systemd service configuration in `nix/module.nix`
- [ ] Phase 2: Create directories before service starts (dataDir, dataDir/git, dataDir/relay)
- [ ] Phase 3: Set proper ownership and permissions
- [ ] Phase 4: Investigate if there are specific custom path options for git and relay data directories
- [ ] Phase 5: Update ExecStartPre logic to handle those paths if they exist
- [x] Phase 1: Add `ExecStartPre` to systemd service configuration in `nix/module.nix`
- [x] Phase 2: Create directories before service starts (dataDir, dataDir/git, dataDir/relay)
- [x] Phase 3: Set proper ownership and permissions
- [x] Phase 4: Investigate if there are specific custom path options for git and relay data directories
- Confirmed: No separate options exist; git/relay paths are derived from dataDir
- [x] Phase 5: Update ExecStartPre logic to handle those paths if they exist
- N/A: Paths are always `${dataDir}/git` and `${dataDir}/relay`
## Implementation
@@ -52,6 +54,16 @@ serviceConfig = {
## Progress
### 2026-01-20 [Session 08:15]
- Completed: Implemented ExecStartPre directives in nix/module.nix
- Implementation details:
- Added 7 ExecStartPre commands with `+` prefix (runs as root)
- Creates dataDir, dataDir/git, dataDir/relay with mkdir -p
- Sets ownership with chown -R to cfg.user:cfg.group
- Sets permissions 750 on all three directories
- Decision: Kept existing tmpfiles.rules for boot-time setup and consistency
- Verified: No separate git/relay path options exist; they're always derived from dataDir
### 2026-01-20 [Session 07:41]
- Started work: Created worktree for implementation