mirror of
https://github.com/minibits-cash/minibits_wallet.git
synced 2026-10-05 11:18:24 +00:00
minibits-cashandClaude Opus 4.8
c56729aa38
Two things, coupled because the first could not be tested without the second. Detect the proofs/mint desync, and change nothing `proofs.mintUrl` is a denormalized copy of a mint's LOCATOR, joined to `mint.mintUrl` by string equality across two persistence engines — proofs in SQLite, mint.mintUrl in the MMKV snapshot. A crash between those writes during a mint-url edit desyncs them, and the balance view then counts the proofs in the unit total while attributing them to no mint, which also makes them unspendable (send and melt select by mint). Money visible in the header, owned by nothing. reportOrphanedProofs() reports that and does nothing else. Deliberate: the sats are the user's, and hiding them, refusing to start, or forcing a recovery are all worse outcomes than a total that reads slightly high. The state self-heals once a mint is (re-)added at that url. It runs at STARTUP, not from `balances`, for two reasons. `balances` is a MobX computed that re-runs on every proof and mint change; and mint removal legitimately produces this exact state for a moment — MintsScreen destroys the mint in one action and moves its proofs to SPENT in the next, so reactions observe the gap. Detecting there would have fired on every normal removal, which is how an alert teaches you to ignore it. At startup the tree is settled, so anything found is a genuine persisted desync. Untangle the model layer MST stores could not be instantiated in a test at all, which is why this repo has no store tests — only mirrored SQL and pure functions. The cause was not jest: the model layer transitively imported most of the app. Five real defects: - logService imported `../models` and destructured rootStoreInstance at MODULE SCOPE, while models/index eagerly instantiates the root store. A leaf logging service pulling the root store inverted the graph, and whether it worked came down to which module loaded first — the app has an entry order that survives it, a test importing a model directly reads RootStoreModel as undefined and throws during import. Now a deferred require, resolved on use. - Mint imported the `../theme` BARREL, which re-exports useThemeColor -> ../services — the whole service layer, to read two colour constants. - Five models imported the `../services` BARREL for log/Database, dragging in walletService -> syncQueueService -> notificationService (notifee). - currency.ts imported the `../../components` BARREL for currency icons: a service module depending on the entire UI. (ChfIcon was already imported directly — it was inconsistent as well as wrong.) - generateId lived in utils.ts beside a react-native-flash-message toast, so generating an id pulled in the UI stack. Split into its own module; utils.ts re-exports it, so existing callers are unaffected. None of these change behaviour: same modules, narrower paths. Test harness jest already used the react-native preset; the gap was native and source-shipped packages that the model layer reaches at import time. Mocks for MMKV (Map-backed, behaves), op-sqlite, Sentry and nostr-tools, plus resolver mappings for @scure/bip39 wordlists and nostr-tools' subpaths — its vendored @noble copies ship source and importing them would cross versions on crypto code, so the surface is mocked instead. op-sqlite and nostr-tools THROW if actually called: a test that silently derives a bogus key and asserts on it is worse than one that stops and explains. Real DB semantics stay where they were, on node:sqlite with the production SQL. Mocking Sentry rather than logService means suites can let the real logger load. The full RootStore still cannot instantiate (AuthStore/NwcStore/ WalletProfileStore pull the service layer), so orphanedProofs.test.ts uses a minimal root — enough for the money models, and enough for what comes next. Also removed: Mint.setRandomColor and theme's getRandomIconColor. The helper's only caller was that action, and the action had no callers at all. Tests: 433 pass, including 12 new ones against the real MST models — the first store tests in the repo. They pin the promise above: an orphaned proof still counts in the unit total, reporting mutates nothing, and it heals when the mint returns. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
47 lines
1.7 KiB
JavaScript
47 lines
1.7 KiB
JavaScript
/**
|
|
* Jest manual mock for nostr-tools and all of its subpaths.
|
|
*
|
|
* nostr-tools ships TypeScript SOURCE and vendors its own @noble/curves and
|
|
* @noble/hashes (also source) which import old-style subpaths jest cannot resolve.
|
|
* Mapping those would silently redirect the nested copies onto the top-level @noble
|
|
* packages — different versions, on crypto code. Not a trade worth making to run a
|
|
* test.
|
|
*
|
|
* This matters far beyond nostr: `services/keyChain` imports nostr-tools, the
|
|
* services barrel imports keyChain, and the MODEL layer imports that barrel — so
|
|
* nostr-tools loads for every store test even though none goes near nostr.
|
|
*
|
|
* Calls throw rather than returning plausible fakes: a test that silently derives a
|
|
* bogus key and asserts on it is worse than one that stops and explains. Code that
|
|
* genuinely needs nostr should mock the calling service (as the existing suites do
|
|
* with nostrService).
|
|
*/
|
|
const makeNamespace = path => {
|
|
const cache = new Map()
|
|
return new Proxy(
|
|
{},
|
|
{
|
|
get(_target, prop) {
|
|
if (prop === '__esModule') return true
|
|
if (prop === 'then') return undefined
|
|
if (typeof prop === 'symbol') return undefined
|
|
|
|
if (!cache.has(prop)) {
|
|
const name = `${path}.${String(prop)}`
|
|
const fn = () => {
|
|
throw new Error(
|
|
`[nostr-tools mock] ${name}() was called in a test. This mock exists ` +
|
|
`only so the module graph resolves — nostr-tools ships TS source ` +
|
|
`with vendored @noble packages. Mock the calling service instead.`,
|
|
)
|
|
}
|
|
cache.set(prop, fn)
|
|
}
|
|
return cache.get(prop)
|
|
},
|
|
},
|
|
)
|
|
}
|
|
|
|
module.exports = makeNamespace('nostr-tools')
|