Fix the two guard failures the harness changes introduced

The internal gate caught both; the cargo quartet cannot see either,
since neither is a compile or test stage.

results_line ended in an echo, so its exit status was the echo's and was
0 whatever the function had done. It only prints a summary and its status
carries nothing, but a caller that tests it would have been reading the
echo. It now returns explicitly.

Three comments cited local tracker identifiers, which a reader holding
only this repository cannot resolve. Each already said what the code does
in the sentences around the citation, so the citations are simply gone
rather than replaced.
This commit is contained in:
Johnathan Corgan
2026-08-22 10:44:25 +01:00
parent 6305287491
commit daf9fa2a17
4 changed files with 4 additions and 3 deletions
+1 -1
View File
@@ -113,7 +113,7 @@ class NodeManager:
and so the `protect_connectivity` guard, and the shared
`down_nodes` set that netem, links and traffic all skip. Returning
before the mutation keeps the model equal to the mesh and lets the
next churn tick retry the node. See ISSUE-2026-0081.
next churn tick retry the node.
"""
container = self.topology.container_name(node_id)
docker_exec_quiet(container, "kill 1", timeout=5) # SIGTERM to PID 1
+1 -1
View File
@@ -587,7 +587,7 @@ class SimRunner:
project before the stragglers have registered, finds nothing to
remove, and says so successfully. Nothing downstream looks at what
survived, so the leak is invisible at the one moment it is cheap to
see. See ISSUE-2026-0079.
see.
"""
log.info("Stopping containers...")
docker_compose(self.compose_file, ["down"], check=False)
+1 -1
View File
@@ -246,7 +246,7 @@ unset -f docker
# --- Case 6: the verdict discriminates non-convergence from connectivity --
#
# This is the break-what-it-guards check for ISSUE-2026-0069. The recorded
# This is the break-what-it-guards check for the verdict itself. The recorded
# failure exited 1 while reporting "20 passed, 0 failed": every connectivity
# pair passed and only the tree fell short, and nothing in the summary told
# the two apart. The gate now names its verdict, so drive it into each
+1
View File
@@ -294,6 +294,7 @@ results_line() {
line+=" relationships, $CONVERGE_OUTCOME)"
fi
echo "$line ==="
return 0
}
phase_result() {