Describe the rekey expiry test in terms a reader outside the project can check

The comment explained the condition by reference to a review round rather than
to the code, which means nothing to anyone reading the test on its own.
This commit is contained in:
Johnathan Corgan
2026-08-15 13:53:33 +00:00
parent 3241872f41
commit 36c91072f0
+4 -4
View File
@@ -281,10 +281,10 @@ fn poll_rekey_expiry_reads_the_handshake_flag_and_never_the_pending_flag() {
let fsp = Fsp::new();
// A completed rekey waiting for its cutover, with an expired peer stamp
// and no handshake beside it. `has_pending` must not stand in for
// `rekey_in_progress` here: widening the condition to either flag is the
// shape the third correction reversed, and it discards the epoch the peer
// has already moved to. The other two arms of this snapshot are quiet, so
// an empty result can only mean the abandon arm declined.
// `rekey_in_progress` here: widening the condition to either flag would
// discard the epoch the peer has already moved to. The other two arms of
// this snapshot are quiet, so an empty result can only mean the abandon
// arm declined.
let mut s = session_snapshot(11);
s.has_pending = true;
s.rekey_in_progress = false;