mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-10-05 19:28:25 +00:00
Claude
a87222c51f
`:commons` is on the CLI classpath, yet it declared Compose UI, Coil, Compose resources, markdown and desktop Compose as dependencies, dragging ~40 MB of UI/Skiko jars into every `amy` distribution. This moves every Compose-dependent file into a new KMP module, `:commonsUI`, that `api`-depends on `:commons`; `:commons` keeps only the Compose runtime (stability annotations + snapshot state) and lifecycle-viewmodel. Files keep their `com.vitorpamplona.amethyst.commons.*` packages, so the split is a build-graph boundary and no consumer import changed. 236 files were `git mv`'d (composables, icons, robohash, theme, Coil fetchers, the `@Composable` relay-client entry points, `composeResources`, and the tests that exercise them). Two headless files needed surgery instead of a move: `GalleryParser` lost a vestigial foundation `@OptIn`, and the `LocalPrivacyLockState`/`lockStateFor` CompositionLocal accessor moved out of `PrivacyLockState` into its own commonsUI file. The feed DAL under `ui/feeds` and `ui/note/ParentNote`+`ReplyContext` stay in `commons` because ViewModels depend on them. `amethyst`, `desktopApp`, `nappletHost` (NappletWebContract serves the shell from composeResources) and `benchmark` now depend on `:commonsUI`; `cli`, `geode` and `marmotBench` do not. commons' androidMain gains an explicit androidx.core KTX dep it previously got transitively through Compose UI. CI, crowdin, the icon-font tools and the escaping hook point at the new composeResources location; CLAUDE.md, commons/ARCHITECTURE.md, a new commonsUI/ARCHITECTURE.md, CONTRIBUTING, BUILDING and the affected skills document the boundary. A plan doc under commons/plans records the classification method and follow-ups. Verified: JVM compiles for commons, commonsUI, cli, desktopApp; Android debug compiles for nappletHost and amethyst; commons/commonsUI/cli JVM test suites; both verifyKmpPurity gates; the cli runtime classpath no longer resolves Compose UI, material3, Skiko or Coil. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01N56KzPSYiN5edMRamvKEgD
21 lines
858 B
Markdown
21 lines
858 B
Markdown
# strings-migrate
|
|
|
|
Moves string keys from the Android app's `res/` into commons Compose
|
|
resources (`commonsUI/src/commonMain/composeResources`) across **all**
|
|
locales in one shot, preserving each element byte-for-byte so Crowdin
|
|
sees a pure move. Both trees are Crowdin-managed with the same android
|
|
layout (see `crowdin.yml`), so a migrated key keeps its translations.
|
|
|
|
```bash
|
|
tools/strings-migrate/migrate.py copy_to_clipboard relay_info
|
|
```
|
|
|
|
After migrating, repoint the code: `R.string.key` becomes `Res.string.key`
|
|
(`com.vitorpamplona.amethyst.commons.resources`), and the composable keeps
|
|
calling `stringRes(...)` via the commons bridge
|
|
(`com.vitorpamplona.amethyst.commons.ui.stringRes`).
|
|
|
|
The tool refuses keys whose value uses bare `%s`/`%d`: compose-resources
|
|
only formats positional `%1$s` args. Rewrite those keys (code and every
|
|
locale) first.
|