mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-08-10 08:27:04 +00:00
nrobi144andClaude Opus 4.6
7ff4d8e3b7
Avatar/Account switcher: - Rewrite SidebarAccountHeader with same shape/hover as other nav items - Entire row (avatar + display name) is clickable with rounded clip - Inline DropdownMenu replaces overlaid AccountSwitcherDropdown - Collapsed: compact avatar with same rounded hover treatment P3 #004 — Hardcoded status colors: - Add StatusGreen/StatusRed/StatusAmber to commons Colors.kt - Replace 32 inline Color() values across 10 files with theme tokens - Color.Red → MaterialTheme.colorScheme.error where appropriate - Color.Green/Gray → StatusGreen/onSurfaceVariant P3 #005 — Inline shapes: - RoundedCornerShape(8.dp) → MaterialTheme.shapes.small (~20 files) - RoundedCornerShape(12.dp) → MaterialTheme.shapes.medium - RoundedCornerShape(16.dp) → MaterialTheme.shapes.large - Pill shapes (100dp/999dp) kept as-is Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
27 lines
875 B
Markdown
27 lines
875 B
Markdown
---
|
|
status: pending
|
|
priority: p3
|
|
issue_id: "005"
|
|
tags: [code-review, theming, desktop]
|
|
---
|
|
|
|
# ~40 inline RoundedCornerShape() calls should use MaterialTheme.shapes
|
|
|
|
## Problem Statement
|
|
|
|
The desktopApp module has ~40 inline `RoundedCornerShape()` calls with values 4dp, 8dp, 10dp, 12dp, 16dp. These should map to `MaterialTheme.shapes.*` tokens for consistency with the unified Amethyst shape system.
|
|
|
|
## Findings
|
|
|
|
Common clusters:
|
|
- `8.dp` (~20 occurrences) → `MaterialTheme.shapes.small`
|
|
- `12.dp` (~5 occurrences) → `MaterialTheme.shapes.medium`
|
|
- `16.dp` (~4 occurrences) → `MaterialTheme.shapes.large`
|
|
- `100.dp` / `999.dp` → pill shapes (acceptable as-is)
|
|
|
|
## Acceptance Criteria
|
|
|
|
- [ ] All 8dp corner shapes use MaterialTheme.shapes.small
|
|
- [ ] All 12dp corner shapes use MaterialTheme.shapes.medium
|
|
- [ ] All 16dp corner shapes use MaterialTheme.shapes.large
|