mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-10-05 19:28:25 +00:00
fix: only say a list has private members when nothing else is on the card
Most lists keep something private, so the note appeared on nearly every card and said nothing the reader could act on. It earns its place only where the card would otherwise be a title and blank space — an all-private list, which is what divine.video publishes — so that it reads as closed rather than broken. RenderVideoCurationSet already gated on an empty member list; this brings the shared frame in line with it. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01JLEq2G6U29mKV8cfSTamZ9
This commit is contained in:
@@ -98,10 +98,11 @@ fun <T> ListCard(
|
||||
)
|
||||
}
|
||||
|
||||
// Said even when some members are public, because otherwise the visible ones read as the whole
|
||||
// list. A list whose members are *all* private — which is what divine.video publishes — would
|
||||
// otherwise show a title and nothing else, and look broken rather than closed.
|
||||
if (hasUnreadablePrivateItems) {
|
||||
// Only when there is nothing else to show. A card with visible members already reads as a list,
|
||||
// and most lists keep something private, so saying so on every one of them is noise. The line
|
||||
// exists for the case that would otherwise be a title and blank space — an all-private list,
|
||||
// which is what divine.video publishes — so that it reads as closed rather than as broken.
|
||||
if (hasUnreadablePrivateItems && items.isEmpty()) {
|
||||
Text(
|
||||
text = stringRes(R.string.nip51_list_has_private_members),
|
||||
style = MaterialTheme.typography.bodySmall,
|
||||
|
||||
Reference in New Issue
Block a user