laantungir/amethyst
1
0
Fork 0
mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-08-11 16:57:39 +00:00
Code Issues Packages Projects Releases Wiki Activity

refactor(sonar): extract NOT_STARTED_MESSAGE constant in CashuWalletState

Browse Source 
Replace the literal "CashuWalletState.start() not called" duplicated across
9 call sites (8 check guards + the publish default lambda) with a single
private companion constant.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This commit is contained in:
davotoula
2026-06-01 21:34:18 +02:00
co-authored by Claude Opus 4.8
parent d8fba6a342
commit ae271d0ba7
1 changed files with 11 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files
amethyst/src/main/java/com/vitorpamplona/amethyst/model/nip60Cashu/CashuWalletState.kt
+11 -9
View File
@@ -879,7 +879,7 @@ class CashuWalletState(
* is loaded.
*/
suspend fun restoreFromMint(mintUrl: String): RestoreOutcome? {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
val seed = ensureSeed() ?: return null
// Heal any prior-Resync duplicates BEFORE running the new
// restore. Without this the existingSecrets set below would
@@ -941,7 +941,7 @@ class CashuWalletState(
* excludes the ghosts.
*/
suspend fun cleanupDuplicateProofs() {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
val entries = _tokenEntries.value
if (entries.size < 2) return
@@ -1019,7 +1019,7 @@ class CashuWalletState(
* caller would still pick the ghosts.
*/
suspend fun scrubLocallyStaleProofs(mintUrlFilter: String? = null) {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
val byMint =
_tokenEntries.value
.groupBy { it.content.mint }
@@ -1075,7 +1075,7 @@ class CashuWalletState(
* migration (e.g. a future "compact wallet" action).
*/
suspend fun migrateStaleKeysets() {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
// Group held tokens by mint URL — each mint has its own keysets.
val byMint = _tokenEntries.value.groupBy { it.content.mint }
for ((mintUrl, entries) in byMint) {
@@ -1107,7 +1107,7 @@ class CashuWalletState(
preferredMintUrl: String? = null,
onProgress: ((Float) -> Unit)? = null,
): NutzapSent {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
val resolved =
peekNutzapTarget(recipientPubKey)
?: throw IllegalStateException("Recipient does not accept nutzaps from any of our mints")
@@ -1160,7 +1160,7 @@ class CashuWalletState(
amountSats: Long,
memo: String? = null,
): SendTokenCompleted {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
if (amountSats <= 0) throw IllegalArgumentException("Amount must be positive")
if (mintUrl.isBlank()) throw IllegalArgumentException("Pick a mint")
@@ -1184,7 +1184,7 @@ class CashuWalletState(
quote: MeltQuoteBolt11ResponseDto,
skipScrub: Boolean = false,
): MeltCompleted {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
if (mintUrl.isBlank()) throw IllegalArgumentException("Pick a mint")
// [rebalance] already scrubbed this mint to compute its coverage check, so
@@ -1220,7 +1220,7 @@ class CashuWalletState(
onProgress: ((Float) -> Unit)? = null,
onFundsMoved: () -> Unit = {},
): RebalanceCompleted {
check(started) { "CashuWalletState.start() not called" }
check(started) { NOT_STARTED_MESSAGE }
require(sats > 0) { "Amount must be positive" }
require(sourceMintUrl != targetMintUrl) { "Source and target mints must differ" }
@@ -1297,7 +1297,7 @@ class CashuWalletState(
* call [publishEvent] is gated behind `started` so the no-op default is
* never observed by produced events.
*/
private var publish: suspend (Event) -> Unit = { error("CashuWalletState.start() not called") }
private var publish: suspend (Event) -> Unit = { error(NOT_STARTED_MESSAGE) }
private suspend fun publishEvent(event: Event) {
publish(event)
@@ -1311,6 +1311,8 @@ class CashuWalletState(
* wallet-less users don't stare at a spinner.
*/
const val DISCOVERY_TIMEOUT_MS = 8_000L
private const val NOT_STARTED_MESSAGE = "CashuWalletState.start() not called"
}
}