refactor(theme): converge filled controls on default colors, drop filledAccent

With onPrimary contrast-picked, the default filled Button/FAB/Switch already
reads correctly on both themes, so the dedicated deep-fill path is redundant.
Remove it everywhere for one uniform look:

- Revert the Save/Post/Send/Create top-bar button and standalone SaveButton to
  plain Button (no colors override).
- Revert all 27 AmethystSwitch call sites back to Switch and delete the
  AmethystSwitch wrapper + amethystSwitchColors.
- Drop the filledAccent / onFilledAccent ColorScheme getters.
- Update the color-pairs preview: primary/onPrimary now covers the whole
  filled-control surface.

The entire filled-control fix is now the single onPrimary = onAccent(primary)
line in the scheme builders.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EVwY2Qzth2EREWg8qLhyzF
This commit is contained in:
Claude
2026-07-17 13:52:39 +00:00
parent 8b3dfafc20
commit a3f42ee45b
33 changed files with 62 additions and 160 deletions
@@ -32,6 +32,7 @@ import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
@@ -47,7 +48,6 @@ import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.navigation.topbars.SavingTopBar
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.grayText
@Composable
@@ -160,7 +160,7 @@ private fun LocalBlossomCacheToggle(accountViewModel: AccountViewModel) {
color = MaterialTheme.colorScheme.grayText,
)
}
AmethystSwitch(
Switch(
checked = enabled,
onCheckedChange = { accountViewModel.account.settings.changeUseLocalBlossomCache(it) },
)
@@ -182,7 +182,7 @@ private fun LocalBlossomCacheToggle(accountViewModel: AccountViewModel) {
color = MaterialTheme.colorScheme.grayText,
)
}
AmethystSwitch(
Switch(
checked = profilePicturesOnly,
onCheckedChange = {
accountViewModel.account.settings.changeLocalBlossomCacheProfilePicturesOnly(it)
@@ -22,7 +22,6 @@ package com.vitorpamplona.amethyst.ui.navigation.topbars
import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.material3.Button
import androidx.compose.material3.ButtonDefaults
import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
@@ -35,8 +34,6 @@ import com.vitorpamplona.amethyst.R
import com.vitorpamplona.amethyst.ui.note.buttons.CloseButton
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.HalfHorzPadding
import com.vitorpamplona.amethyst.ui.theme.filledAccent
import com.vitorpamplona.amethyst.ui.theme.onFilledAccent
@OptIn(ExperimentalMaterial3Api::class)
@Composable
@@ -74,11 +71,6 @@ fun ActionTopBar(
modifier = HalfHorzPadding,
enabled = isActive(),
onClick = onPost,
colors =
ButtonDefaults.buttonColors(
containerColor = MaterialTheme.colorScheme.filledAccent,
contentColor = MaterialTheme.colorScheme.onFilledAccent,
),
) {
Text(text = stringRes(postRes))
}
@@ -21,15 +21,11 @@
package com.vitorpamplona.amethyst.ui.note.buttons
import androidx.compose.material3.Button
import androidx.compose.material3.ButtonDefaults
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
import com.vitorpamplona.amethyst.R
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.filledAccent
import com.vitorpamplona.amethyst.ui.theme.onFilledAccent
@Composable
fun SaveButton(
@@ -41,11 +37,6 @@ fun SaveButton(
enabled = isActive,
modifier = modifier,
onClick = onPost,
colors =
ButtonDefaults.buttonColors(
containerColor = MaterialTheme.colorScheme.filledAccent,
contentColor = MaterialTheme.colorScheme.onFilledAccent,
),
) {
Text(text = stringRes(R.string.save))
}
@@ -27,6 +27,7 @@ import androidx.compose.foundation.layout.fillMaxWidth
import androidx.compose.foundation.layout.padding
import androidx.compose.foundation.selection.toggleable
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
@@ -36,7 +37,6 @@ import androidx.compose.ui.semantics.Role
import androidx.compose.ui.text.style.TextOverflow
import androidx.compose.ui.unit.dp
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
@Composable
fun SettingSwitchItem(
@@ -81,7 +81,7 @@ fun SettingSwitchItem(
}
Column(Modifier.weight(1f), horizontalAlignment = Alignment.End) {
AmethystSwitch(
Switch(
checked = checked,
onCheckedChange = null,
enabled = enabled,
@@ -32,6 +32,7 @@ import androidx.compose.foundation.layout.size
import androidx.compose.material3.DropdownMenu
import androidx.compose.material3.DropdownMenuItem
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
@@ -52,7 +53,6 @@ import com.vitorpamplona.amethyst.model.Note
import com.vitorpamplona.amethyst.service.playback.composable.MediaControllerState
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.grayText
import com.vitorpamplona.quartz.podcasts.PodcastStreamingAccrual
import com.vitorpamplona.quartz.podcasts.PodcastValue
@@ -206,7 +206,7 @@ fun PodcastStreamingControl(
)
}
AmethystSwitch(
Switch(
checked = enabled,
onCheckedChange = { wantOn ->
if (wantOn && !hasInAppWallet) {
@@ -37,6 +37,7 @@ import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
@@ -72,7 +73,6 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.apps.recommendations.datasource.ProfileAppRecommendationsFilterAssemblerSubscription
import com.vitorpamplona.amethyst.ui.screen.loggedIn.relays.kindDisplayName
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size20Modifier
import com.vitorpamplona.amethyst.ui.theme.placeholderText
import com.vitorpamplona.quartz.kinds.KindNames
@@ -402,7 +402,7 @@ private fun AppRow(
Spacer(modifier = Modifier.size(12.dp))
AmethystSwitch(
Switch(
checked = isRecommended,
enabled = canToggle,
onCheckedChange = { checked ->
@@ -34,6 +34,7 @@ import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
@@ -62,7 +63,6 @@ import com.vitorpamplona.amethyst.ui.note.LoadAddressableNote
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.badges.profile.datasource.ProfileBadgesFilterAssemblerSubscription
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.quartz.nip58Badges.accepted.AcceptedBadgeSetEvent
import com.vitorpamplona.quartz.nip58Badges.award.BadgeAwardEvent
import com.vitorpamplona.quartz.nip58Badges.definition.BadgeDefinitionEvent
@@ -280,7 +280,7 @@ private fun StaticAwardRow(
Spacer(modifier = Modifier.size(12.dp))
AmethystSwitch(
Switch(
checked = isAccepted,
enabled = definition != null,
onCheckedChange = { checked ->
@@ -31,6 +31,7 @@ import androidx.compose.material3.FilterChip
import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TopAppBar
import androidx.compose.runtime.Composable
@@ -51,7 +52,6 @@ import com.vitorpamplona.amethyst.service.calendar.CalendarReminderPrefs
import com.vitorpamplona.amethyst.service.calendar.CalendarReminderWorker
import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
@OptIn(ExperimentalMaterial3Api::class)
@Composable
@@ -100,7 +100,7 @@ fun CalendarReminderSettingsScreen(nav: INav) {
color = MaterialTheme.colorScheme.onSurfaceVariant,
)
}
AmethystSwitch(
Switch(
checked = enabled,
onCheckedChange = {
enabled = it
@@ -39,6 +39,7 @@ import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.DisposableEffect
@@ -67,7 +68,6 @@ import com.vitorpamplona.amethyst.ui.note.creators.userSuggestions.UserSuggestio
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.chats.rooms.LoadUser
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size30dp
import com.vitorpamplona.amethyst.ui.theme.SuggestionListDefaultHeightChat
import kotlinx.coroutines.launch
@@ -214,7 +214,7 @@ private fun AllDayToggleRow(vm: NewCalendarEventViewModel) {
)
}
}
AmethystSwitch(
Switch(
checked = vm.isAllDay.value,
onCheckedChange = { vm.isAllDay.value = it },
enabled = !vm.isEditing,
@@ -43,6 +43,7 @@ import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Surface
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
@@ -73,7 +74,6 @@ import com.vitorpamplona.amethyst.ui.navigation.topbars.SavingTopBar
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.chats.publicChannels.relayGroup.datasource.RelayGroupWarmupSubscription
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.quartz.nip01Core.relay.normalizer.RelayUrlNormalizer
import com.vitorpamplona.quartz.nip29RelayGroups.GroupId
@@ -443,6 +443,6 @@ private fun LabeledSwitchRow(
color = MaterialTheme.colorScheme.onSurfaceVariant,
)
}
AmethystSwitch(checked = checked, onCheckedChange = onChange)
Switch(checked = checked, onCheckedChange = onChange)
}
}
@@ -56,6 +56,7 @@ import androidx.compose.material3.OutlinedTextFieldDefaults
import androidx.compose.material3.Scaffold
import androidx.compose.material3.SecondaryTabRow
import androidx.compose.material3.Surface
import androidx.compose.material3.Switch
import androidx.compose.material3.Tab
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
@@ -118,7 +119,6 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.home.ObserveInboxRelayListAndDisplayIfNotFound
import com.vitorpamplona.amethyst.ui.screen.loggedIn.settings.SettingsRow
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size10dp
import com.vitorpamplona.amethyst.ui.theme.Size5dp
import com.vitorpamplona.amethyst.ui.theme.SuggestionListDefaultHeightPage
@@ -447,7 +447,7 @@ private fun MarkdownPostScreenBody(
R.string.geohash_exclusive,
R.string.geohash_exclusive_explainer,
) {
AmethystSwitch(postViewModel.wantsExclusiveGeoPost, onCheckedChange = { postViewModel.wantsExclusiveGeoPost = it })
Switch(postViewModel.wantsExclusiveGeoPost, onCheckedChange = { postViewModel.wantsExclusiveGeoPost = it })
}
}
}
@@ -42,6 +42,7 @@ import androidx.compose.foundation.shape.RoundedCornerShape
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Surface
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
@@ -56,7 +57,6 @@ import com.vitorpamplona.amethyst.R
import com.vitorpamplona.amethyst.commons.icons.symbols.Icon
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbol
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.commons.R as CommonsR
/**
@@ -246,6 +246,6 @@ private fun SheetSwitchItem(
Icon(symbol, contentDescription = null, modifier = Modifier.size(22.dp), tint = MaterialTheme.colorScheme.onSurfaceVariant)
Spacer(Modifier.width(14.dp))
Text(label, style = MaterialTheme.typography.bodyLarge, modifier = Modifier.weight(1f))
AmethystSwitch(checked = checked, onCheckedChange = { onToggle() })
Switch(checked = checked, onCheckedChange = { onToggle() })
}
}
@@ -31,6 +31,7 @@ import androidx.compose.material3.AlertDialog
import androidx.compose.material3.Button
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.derivedStateOf
@@ -48,7 +49,6 @@ import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.ui.actions.uploads.SelectSingleFromGallery
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.DoubleVertSpacer
import com.vitorpamplona.quartz.nip01Core.core.Address
import com.vitorpamplona.quartz.nip30CustomEmoji.EmojiUrlTag
@@ -146,7 +146,7 @@ fun AddEmojiDialog(
text = stringRes(R.string.emoji_private_toggle),
modifier = Modifier.weight(1f),
)
AmethystSwitch(
Switch(
checked = isPrivate,
onCheckedChange = { isPrivate = it },
)
@@ -49,6 +49,7 @@ import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextFieldDefaults
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Surface
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
@@ -127,7 +128,6 @@ import com.vitorpamplona.amethyst.ui.note.types.ReplyRenderType
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.settings.SettingsRow
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.DividerThickness
import com.vitorpamplona.amethyst.ui.theme.Font14SP
import com.vitorpamplona.amethyst.ui.theme.Size10dp
@@ -536,7 +536,7 @@ private fun NewPostScreenBody(
R.string.geohash_exclusive,
R.string.geohash_exclusive_explainer,
) {
AmethystSwitch(postViewModel.wantsExclusiveGeoPost, onCheckedChange = { postViewModel.wantsExclusiveGeoPost = it })
Switch(postViewModel.wantsExclusiveGeoPost, onCheckedChange = { postViewModel.wantsExclusiveGeoPost = it })
}
}
}
@@ -44,6 +44,7 @@ import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedButton
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
@@ -81,7 +82,6 @@ import com.vitorpamplona.amethyst.ui.note.LoadAddressableNote
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.mockAccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonColumn
import com.vitorpamplona.quartz.experimental.music.track.MusicTrackEvent
import kotlinx.collections.immutable.persistentListOf
@@ -259,7 +259,7 @@ private fun LabeledSwitchRow(
)
}
Spacer(Modifier.size(12.dp))
AmethystSwitch(
Switch(
checked = checked,
onCheckedChange = onCheckedChange,
enabled = enabled,
@@ -38,6 +38,7 @@ import androidx.compose.material3.ExperimentalMaterial3Api
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.ModalBottomSheet
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.material3.rememberModalBottomSheetState
@@ -61,7 +62,6 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.nests.NestsScreen
import com.vitorpamplona.amethyst.ui.screen.loggedIn.nests.room.activity.NestActivity
import com.vitorpamplona.amethyst.ui.screen.loggedIn.nests.room.activity.NestBridge
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.placeholderText
import kotlinx.coroutines.launch
import android.text.format.DateFormat as AndroidDateFormat
@@ -171,7 +171,7 @@ fun CreateNestSheet(
modifier = Modifier.fillMaxWidth(),
verticalAlignment = androidx.compose.ui.Alignment.CenterVertically,
) {
AmethystSwitch(
Switch(
checked = state.scheduled,
onCheckedChange = viewModel::onScheduledToggle,
)
@@ -35,6 +35,7 @@ import androidx.compose.material3.FilterChip
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.LaunchedEffect
@@ -58,7 +59,6 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.music.CoverImagePicker
import com.vitorpamplona.amethyst.ui.screen.loggedIn.music.UploadInProgressBanner
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import kotlinx.collections.immutable.persistentListOf
/**
@@ -207,6 +207,6 @@ private fun SwitchRow(
verticalAlignment = Alignment.CenterVertically,
) {
Text(text = label, style = MaterialTheme.typography.bodyLarge, modifier = Modifier.weight(1f))
AmethystSwitch(checked = checked, onCheckedChange = onChange)
Switch(checked = checked, onCheckedChange = onChange)
}
}
@@ -25,6 +25,7 @@ import androidx.compose.foundation.layout.Spacer
import androidx.compose.foundation.lazy.LazyColumn
import androidx.compose.foundation.lazy.LazyListScope
import androidx.compose.foundation.lazy.itemsIndexed
import androidx.compose.material3.Switch
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
import androidx.compose.ui.Alignment
@@ -41,7 +42,6 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.relays.common.RelayUrlEditF
import com.vitorpamplona.amethyst.ui.screen.loggedIn.relays.common.relaySetupInfoBuilder
import com.vitorpamplona.amethyst.ui.screen.loggedIn.relays.common.rememberRelayDragState
import com.vitorpamplona.amethyst.ui.screen.loggedIn.settings.SettingsRow
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.FeedPadding
import com.vitorpamplona.amethyst.ui.theme.HorzHalfVertPadding
import com.vitorpamplona.amethyst.ui.theme.HorzPadding
@@ -103,7 +103,7 @@ fun LazyListScope.renderLocalItems(
) {
val checked by accountViewModel.account.settings.syncedSettings.security.sendKind0EventsToLocalRelay
.collectAsStateWithLifecycle()
AmethystSwitch(
Switch(
checked = checked,
onCheckedChange = {
accountViewModel.toggleSendKind0ToLocalRelay(it)
@@ -52,6 +52,7 @@ import androidx.compose.material3.RadioButton
import androidx.compose.material3.SegmentedButton
import androidx.compose.material3.SegmentedButtonDefaults
import androidx.compose.material3.SingleChoiceSegmentedButtonRow
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.material3.TextField
@@ -98,7 +99,6 @@ import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.chats.rooms.ChannelName
import com.vitorpamplona.amethyst.ui.screen.loggedIn.relays.common.BasicRelaySetupInfoClickableRow
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.DividerThickness
import com.vitorpamplona.amethyst.ui.theme.FeedPadding
import com.vitorpamplona.amethyst.ui.theme.Size20Modifier
@@ -408,7 +408,7 @@ private fun SearchFiltersSheet(
modifier = Modifier.weight(1f),
style = MaterialTheme.typography.bodyLarge,
)
AmethystSwitch(
Switch(
checked = followsOnly,
onCheckedChange = onFollowsOnlyChange,
)
@@ -47,6 +47,7 @@ import androidx.compose.material3.Scaffold
import androidx.compose.material3.SegmentedButton
import androidx.compose.material3.SegmentedButtonDefaults
import androidx.compose.material3.SingleChoiceSegmentedButtonRow
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState
@@ -89,7 +90,6 @@ import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.navigation.topbars.TopBarWithBackButton
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonRow
import com.vitorpamplona.amethyst.ui.theme.contentColorOnAccent
import com.vitorpamplona.amethyst.ui.theme.isLight
@@ -246,7 +246,7 @@ private fun BooleanSwitchTile(
description = stringRes(description),
onClick = { toggle(!checked) },
) {
AmethystSwitch(checked = checked, onCheckedChange = toggle)
Switch(checked = checked, onCheckedChange = toggle)
}
}
@@ -38,6 +38,7 @@ import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.RadioButton
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState
@@ -60,7 +61,6 @@ import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.navigation.topbars.TopBarWithBackButton
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
@Composable
fun CallSettingsScreen(
@@ -162,7 +162,7 @@ private fun EnableCallsSection(
)
}
Spacer(modifier = Modifier.width(16.dp))
AmethystSwitch(
Switch(
checked = enabled,
onCheckedChange = onEnabledChanged,
)
@@ -33,6 +33,7 @@ import androidx.compose.material3.Scaffold
import androidx.compose.material3.SegmentedButton
import androidx.compose.material3.SegmentedButtonDefaults
import androidx.compose.material3.SingleChoiceSegmentedButtonRow
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.collectAsState
@@ -59,7 +60,6 @@ import com.vitorpamplona.amethyst.ui.note.creators.pow.POW_PRESETS
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.mockAccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonColumn
import kotlinx.coroutines.flow.MutableStateFlow
@@ -233,7 +233,7 @@ private fun PowCategoryChecklist(accountViewModel: AccountViewModel) {
description = stringRes(category.descriptionRes()),
enabled = miningOn,
) {
AmethystSwitch(
Switch(
checked = checked,
enabled = miningOn,
onCheckedChange = { accountViewModel.updatePowCategory(category, it) },
@@ -339,7 +339,7 @@ private fun SwitchTile(
description = stringRes(description),
onClick = { onCheckedChange(!checked) },
) {
AmethystSwitch(checked = checked, onCheckedChange = onCheckedChange)
Switch(checked = checked, onCheckedChange = onCheckedChange)
}
}
@@ -31,6 +31,7 @@ import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
@@ -48,7 +49,6 @@ import com.vitorpamplona.amethyst.ui.navigation.topbars.TopBarWithBackButton
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.mockAccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size20dp
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonRow
@@ -159,7 +159,7 @@ private fun HomeTabSwitchRow(
overflow = TextOverflow.Ellipsis,
modifier = Modifier.weight(1f),
)
AmethystSwitch(
Switch(
checked = checked,
enabled = enabled,
onCheckedChange = onCheckedChange,
@@ -47,6 +47,7 @@ import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.RadioButton
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
@@ -73,7 +74,6 @@ import com.vitorpamplona.amethyst.commons.icons.symbols.Icon
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.commons.model.nip05DnsIdentifiers.namecoin.NamecoinSettings
import com.vitorpamplona.amethyst.ui.note.formatMediumDateTime
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.quartz.nip05DnsIdentifiers.namecoin.DEFAULT_ELECTRUMX_SERVERS
import com.vitorpamplona.quartz.nip05DnsIdentifiers.namecoin.ElectrumxServer
import com.vitorpamplona.quartz.nip05DnsIdentifiers.namecoin.NamecoinBackend
@@ -602,7 +602,7 @@ private fun SectionHeader(
)
}
}
AmethystSwitch(
Switch(
checked = enabled,
onCheckedChange = onToggle,
)
@@ -1294,7 +1294,7 @@ private fun ToggleRow(
color = MaterialTheme.colorScheme.onSurfaceVariant,
)
}
AmethystSwitch(
Switch(
checked = checked,
onCheckedChange = onCheckedChange,
enabled = enabled,
@@ -34,6 +34,7 @@ import androidx.compose.material3.Card
import androidx.compose.material3.CardDefaults
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
@@ -67,7 +68,6 @@ import com.vitorpamplona.amethyst.ui.note.toShortDisplay
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.mockAccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonColumn
@Composable
@@ -166,7 +166,7 @@ private fun AccountParticipationRow(
description = stringRes(R.string.notification_service_participation_title),
onClick = { settings.toggleAlwaysOnNotificationService() },
) {
AmethystSwitch(
Switch(
checked = participates,
onCheckedChange = { settings.toggleAlwaysOnNotificationService() },
)
@@ -31,6 +31,7 @@ import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
@@ -52,7 +53,6 @@ import com.vitorpamplona.amethyst.ui.navigation.topbars.TopBarWithBackButton
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.mockAccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size20dp
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonRow
import kotlinx.collections.immutable.persistentListOf
@@ -192,7 +192,7 @@ private fun ProfileUiSwitchRow(
overflow = TextOverflow.Ellipsis,
modifier = Modifier.weight(1f),
)
AmethystSwitch(
Switch(
checked = checked,
onCheckedChange = onCheckedChange,
)
@@ -37,6 +37,7 @@ import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.getValue
@@ -68,7 +69,6 @@ import com.vitorpamplona.amethyst.ui.navigation.topbars.TopBarWithBackButton
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.screen.loggedIn.mockAccountViewModel
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size20dp
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonRow
@@ -319,7 +319,7 @@ private fun ReactionRowItemCard(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp),
) {
AmethystSwitch(
Switch(
checked = item.enabled,
onCheckedChange = { onToggleEnabled() },
)
@@ -335,7 +335,7 @@ private fun ReactionRowItemCard(
verticalAlignment = Alignment.CenterVertically,
horizontalArrangement = Arrangement.spacedBy(8.dp),
) {
AmethystSwitch(
Switch(
checked = item.showCounter,
onCheckedChange = { onToggleCounter() },
enabled = item.enabled,
@@ -38,6 +38,7 @@ import androidx.compose.material3.CardDefaults
import androidx.compose.material3.HorizontalDivider
import androidx.compose.material3.IconButton
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.ui.Alignment
@@ -53,7 +54,6 @@ import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbol
import com.vitorpamplona.amethyst.commons.icons.symbols.MaterialSymbols
import com.vitorpamplona.amethyst.ui.painterRes
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import androidx.compose.material3.Icon as Material3Icon
@Composable
@@ -268,7 +268,7 @@ internal fun SettingsSwitchTile(
description = stringRes(description),
onClick = { onCheckedChange(!checked) },
) {
AmethystSwitch(checked = checked, onCheckedChange = onCheckedChange)
Switch(checked = checked, onCheckedChange = onCheckedChange)
}
}
@@ -55,6 +55,7 @@ import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedButton
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.material3.TextButton
import androidx.compose.runtime.Composable
@@ -84,7 +85,6 @@ import com.vitorpamplona.amethyst.ui.components.TitleExplainer
import com.vitorpamplona.amethyst.ui.navigation.navs.INav
import com.vitorpamplona.amethyst.ui.navigation.topbars.TopBarWithBackButton
import com.vitorpamplona.amethyst.ui.screen.loggedIn.AccountViewModel
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import kotlinx.collections.immutable.toImmutableList
import kotlinx.coroutines.Dispatchers
import kotlinx.coroutines.withContext
@@ -307,7 +307,7 @@ private fun FormFields(vm: NewHlsVideoViewModel) {
modifier = Modifier.weight(1f),
style = MaterialTheme.typography.bodyLarge,
)
AmethystSwitch(
Switch(
checked = vm.sensitiveContent,
onCheckedChange = { vm.sensitiveContent = it },
)
@@ -1,63 +0,0 @@
/*
* Copyright (c) 2025 Vitor Pamplona
*
* Permission is hereby granted, free of charge, to any person obtaining a copy of
* this software and associated documentation files (the "Software"), to deal in
* the Software without restriction, including without limitation the rights to use,
* copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the
* Software, and to permit persons to whom the Software is furnished to do so,
* subject to the following conditions:
*
* The above copyright notice and this permission notice shall be included in all
* copies or substantial portions of the Software.
*
* THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR
* IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS
* FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR
* COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN
* AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION
* WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE.
*/
package com.vitorpamplona.amethyst.ui.theme
import androidx.compose.foundation.interaction.MutableInteractionSource
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.Switch
import androidx.compose.material3.SwitchColors
import androidx.compose.material3.SwitchDefaults
import androidx.compose.runtime.Composable
import androidx.compose.ui.Modifier
// Checked-state colors for every switch in the app. The checked track/border use the deep
// filledAccent (not the light `primary`, which washes out as a fill on the dark theme) and the
// thumb uses onFilledAccent so it stays legible on top. Unchecked colors keep Material's neutral
// grays.
@Composable
fun amethystSwitchColors(): SwitchColors =
SwitchDefaults.colors(
checkedThumbColor = MaterialTheme.colorScheme.onFilledAccent,
checkedTrackColor = MaterialTheme.colorScheme.filledAccent,
checkedBorderColor = MaterialTheme.colorScheme.filledAccent,
checkedIconColor = MaterialTheme.colorScheme.filledAccent,
)
// Drop-in replacement for Material3's Switch that applies amethystSwitchColors() by default, so the
// accent fill stays consistent everywhere. Mirrors the Switch signature; pass `colors` to override.
@Composable
fun AmethystSwitch(
checked: Boolean,
onCheckedChange: ((Boolean) -> Unit)?,
modifier: Modifier = Modifier,
thumbContent: (@Composable () -> Unit)? = null,
enabled: Boolean = true,
colors: SwitchColors = amethystSwitchColors(),
interactionSource: MutableInteractionSource? = null,
) = Switch(
checked = checked,
onCheckedChange = onCheckedChange,
modifier = modifier,
thumbContent = thumbContent,
enabled = enabled,
colors = colors,
interactionSource = interactionSource,
)
@@ -66,18 +66,12 @@ private class RolePair(
private val ROLE_PAIRS =
listOf(
RolePair(
"filledAccent / onFilledAccent",
{ it.filledAccent },
{ it.onFilledAccent },
"Top-bar Save·Post·Send·Create button, standalone Save button, checked switch.",
highlight = true,
),
RolePair(
"primary / onPrimary",
{ it.primary },
{ it.onPrimary },
"Floating action buttons, generic filled buttons, sliders, progress.",
"Top-bar Save button, FABs, filled buttons, checked switch, sliders, progress.",
highlight = true,
),
RolePair(
"primaryContainer / onPrimaryContainer",
@@ -545,18 +545,6 @@ val ColorScheme.selectedNote: Color
val ColorScheme.secondaryButtonBackground: Color
get() = primary.copy(alpha = 0.32f).compositeOver(background)
// Solid fill for accent-colored controls (the top-bar Save/Post/Send button, checked switches).
// On dark themes `primary` is a light pastel tuned for text/icons on black; used as a button/switch
// fill under white content it washes out. Deepen it halfway toward the accent's deep (light-theme)
// variant — the scheme already carries that as inversePrimary — so filled controls read as a rich,
// saturated accent. Light themes already use the deep variant as primary, so they keep it unchanged.
val ColorScheme.filledAccent: Color
get() = if (isLight) primary else lerp(primary, inversePrimary, 0.5f)
// Black or white for content on a filledAccent surface — whichever wins the WCAG contrast check.
val ColorScheme.onFilledAccent: Color
get() = onAccent(filledAccent)
val ColorScheme.lessImportantLink: Color
get() = primary.copy(alpha = 0.52f)
@@ -35,6 +35,7 @@ import androidx.compose.foundation.verticalScroll
import androidx.compose.material3.MaterialTheme
import androidx.compose.material3.OutlinedTextField
import androidx.compose.material3.Scaffold
import androidx.compose.material3.Switch
import androidx.compose.material3.Text
import androidx.compose.runtime.Composable
import androidx.compose.runtime.MutableState
@@ -58,7 +59,6 @@ import com.vitorpamplona.amethyst.ui.components.TitleExplainer
import com.vitorpamplona.amethyst.ui.navigation.topbars.SavingTopBar
import com.vitorpamplona.amethyst.ui.screen.loggedIn.settings.SettingsRow
import com.vitorpamplona.amethyst.ui.stringRes
import com.vitorpamplona.amethyst.ui.theme.AmethystSwitch
import com.vitorpamplona.amethyst.ui.theme.Size10dp
import com.vitorpamplona.amethyst.ui.theme.ThemeComparisonColumn
import com.vitorpamplona.amethyst.ui.theme.placeholderText
@@ -314,6 +314,6 @@ fun SwitchSettingsRow(
name,
desc,
) {
AmethystSwitch(checked.value, onCheckedChange = { checked.value = it })
Switch(checked.value, onCheckedChange = { checked.value = it })
}
}