laantungir/amethyst
1
0
Fork 0
mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-08-09 08:04:45 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: narrow app release observer to the app's i-tag

Browse Source 
The version-chip observer filtered releases by author only, so an
author with many apps pulled every release they ever published into the
observer's working set. Narrow the filter on the release `i` tag (the
app id) so only this app's releases are loaded.

A blind limit is avoided on purpose: LocalCache.filter applies
take(limit) before sorting by created_at, so a limit could drop the
latest release the chip needs.

Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01EbCTsBoGtBCJ1rTKCcar6w
This commit is contained in:
Claude
2026-06-20 03:25:05 +00:00
parent cbbba279a7
commit 9da1df57b9
1 changed files with 11 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
amethyst/src/main/java/com/vitorpamplona/amethyst/ui/note/types/SoftwareApp.kt
+11 -4
View File
@@ -92,6 +92,7 @@ import com.vitorpamplona.quartz.experimental.nip82SoftwareApps.asset.SoftwareAss
import com.vitorpamplona.quartz.experimental.nip82SoftwareApps.release.SoftwareReleaseEvent
import com.vitorpamplona.quartz.experimental.nip82SoftwareApps.release.asSoftwareRelease
import com.vitorpamplona.quartz.experimental.nip82SoftwareApps.release.isNip82SoftwareRelease
import com.vitorpamplona.quartz.experimental.nip82SoftwareApps.release.tags.AppIdTag
import com.vitorpamplona.quartz.nip01Core.relay.filters.Filter
import com.vitorpamplona.quartz.nip01Core.tags.dTag.dTag
import kotlinx.collections.immutable.toImmutableList
@@ -198,10 +199,15 @@ fun RenderSoftwareApplication(
* Releases (kind 30063) are separate events that point back to the app via an
* `i` tag rather than an `a` tag, so they are never indexed as replies to the
* app note and never ping its flows. Instead we register an index-driven
* [LocalCache.observeNotes] observer keyed on kind-30063 / author, so a newer
* release arriving while the card is visible updates the version chip without
* a manual refresh. The observer only wakes on matching insertions, so it is
* far cheaper than re-scanning the cache on every new-event bundle.
* [LocalCache.observeNotes] observer, so a newer release arriving while the
* card is visible updates the version chip without a manual refresh.
*
* The filter narrows on the release's `i` tag (the app id), not just the
* author, so the observer only ever loads *this* app's releases — an author
* with many apps would otherwise pull every release they ever published into
* the observer's working set. A blind `limit` is deliberately avoided:
* [LocalCache.filter] applies `take(limit)` before sorting by `created_at`,
* so it could drop the very release we are looking for.
*/
@Composable
fun produceLatestReleaseVersion(app: SoftwareApplicationEvent): State<String?> {
@@ -211,6 +217,7 @@ fun produceLatestReleaseVersion(app: SoftwareApplicationEvent): State<String?> {
Filter(
kinds = listOf(SoftwareReleaseEvent.KIND),
authors = listOf(app.pubKey),
tags = mapOf(AppIdTag.TAG_NAME to listOf(app.appId())),
)
LocalCache
.observeNotes(filter)