laantungir/amethyst
1
0
Fork 0
mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-10-06 11:48:24 +00:00
Code Issues Packages Projects Releases Wiki Activity

Code review:

Browse Source 
- guard shared NSDateFormatter in formattedDateTime iOS actual
This commit is contained in:
davotoula
2026-05-26 14:53:38 +02:00
parent 5ec60e285b
commit 771ba67f31
1 changed files with 13 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files
commons/src/iosMain/kotlin/com/vitorpamplona/amethyst/commons/model/ThreadLevelCalculator.ios.kt
+13 -1
View File
@@ -22,6 +22,8 @@
package com.vitorpamplona.amethyst.commons.model
import com.vitorpamplona.amethyst.commons.util.KmpLock
import com.vitorpamplona.amethyst.commons.util.withLock
import platform.Foundation.NSDate
import platform.Foundation.NSDateFormatter
import platform.Foundation.NSLocale
@@ -39,4 +41,14 @@ private val levelFormatter: NSDateFormatter =
locale = NSLocale("en_US_POSIX")
}
actual fun formattedDateTime(timestamp: Long): String = levelFormatter.stringFromDate(NSDate.dateWithTimeIntervalSince1970(timestamp.toDouble()))
// NSDateFormatter is not thread-safe for concurrent stringFromDate calls
// (Apple docs). ThreadLevelCalculator.replyLevelSignature runs under
// Dispatchers.IO via LevelFeedViewModel, so multiple threads can hit
// formattedDateTime simultaneously. Guard the shared formatter rather than
// allocating one per call (cheaper for the O(notes-per-thread-sort) call rate).
private val levelFormatterLock = KmpLock()
actual fun formattedDateTime(timestamp: Long): String =
levelFormatterLock.withLock {
levelFormatter.stringFromDate(NSDate.dateWithTimeIntervalSince1970(timestamp.toDouble()))
}