laantungir/amethyst
1
0
Fork 0
mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-08-11 08:47:33 +00:00
Code Issues Packages Projects Releases Wiki Activity

fix: log unparseable relay frames at WARN, not ERROR

Browse Source 
A frame the client can't decode (non-standard framing, unknown command,
malformed JSON) is a relay-side quirk, not an Amethyst error. For example,
multiplextr.coracle.social replies to a plain REQ with its own multiplexer
envelope `[{"relays":[]},["NOTICE","","Unable to handle message"]]`, whose
first element is an object rather than a command label, so the decoder
throws `Message null is not supported`.

BasicRelayClient already drops such frames and its comment states it
"doesn't expose parsing errors to lib users as errors", yet it logged at
ERROR. Downgrade to WARN so these relay-side quirks stop surfacing as app
errors.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01THVD3sY6xrxGzBHhUnhJAY
This commit is contained in:
Claude
2026-07-07 22:14:39 +00:00
parent 607665e846
commit 722d9526a1
1 changed files with 4 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files
quartz/src/commonMain/kotlin/com/vitorpamplona/quartz/nip01Core/relay/client/single/basic/BasicRelayClient.kt
+4 -2
View File
@@ -160,8 +160,10 @@ open class BasicRelayClient(
listener.onIncomingMessage(this@BasicRelayClient, text, msg)
} catch (e: Throwable) {
if (e is CancellationException) throw e
// doesn't expose parsing errors to lib users as errors
Log.e("BasicRelayClient", "Failure to parse message from ${url.url}: $text", e)
// A frame we can't parse is a relay-side quirk (non-standard framing, an
// unknown command, malformed JSON), not an Amethyst error. Drop it and log
// at WARN so it doesn't surface as an app error to lib users.
Log.w("BasicRelayClient", "Failure to parse message from ${url.url}: $text", e)
}
}