laantungir/amethyst
1
0
Fork 0
mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-08-10 08:27:04 +00:00
Code Issues Packages Projects Releases Wiki Activity

perf: keep ColorScheme.isLight O(1) after accent-color change

Browse Source 
isLight fans out to hundreds of themed-color getters on hot note/chat/feed
render paths. The accent-color work had switched it to background.luminance(),
which adds per-call gamma math. Since the accent never touches background
(only primary/secondary) and the dark palette's background is exactly
Color.Black, a single reference comparison is just as accent-robust and
restores the original constant-time cost.

Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01REGsru6cnm6wUzqm12Rh2d
This commit is contained in:
Claude
2026-06-27 19:56:53 +00:00
parent 1069fb0701
commit 373aa7d740
1 changed files with 5 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files
amethyst/src/main/java/com/vitorpamplona/amethyst/ui/theme/Theme.kt
+5 -4
View File
@@ -46,7 +46,6 @@ import androidx.compose.ui.graphics.Color
import androidx.compose.ui.graphics.ColorFilter
import androidx.compose.ui.graphics.RectangleShape
import androidx.compose.ui.graphics.compositeOver
import androidx.compose.ui.graphics.luminance
import androidx.compose.ui.graphics.toArgb
import androidx.compose.ui.platform.LocalContext
import androidx.compose.ui.platform.LocalDensity
@@ -423,10 +422,12 @@ val MarkDownStyleOnLight =
),
)
// Derived from background luminance instead of a fixed primary so the check keeps working
// when the user picks a non-purple accent color (only primary/secondary change, not background).
// Compared against the dark palette's background instead of a fixed primary so the check keeps
// working when the user picks a non-purple accent (accent only changes primary/secondary, never
// background). Kept as a single reference comparison because this getter fans out to hundreds of
// themed-color call sites on hot rendering paths — luminance()/etc. would add real per-frame cost.
val ColorScheme.isLight: Boolean
get() = background.luminance() > 0.5f
get() = background != Color.Black
// The accent-derived tints below are computed from the live scheme's primary so they follow
// the selected accent color. Color is an inline value class, so these copies don't allocate.