From fd051d3bb944605115f2d599995cc0f5aed51a9f Mon Sep 17 00:00:00 2001 From: kdmukai <934746+kdmukai@users.noreply.github.com> Date: Sat, 27 Dec 2025 14:20:33 -0600 Subject: [PATCH] Minor comments updates --- tests/screenshot_generator/generator.py | 5 +++-- tests/screenshot_generator/utils.py | 7 ++++--- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py index a7294fd9..d5345ba5 100644 --- a/tests/screenshot_generator/generator.py +++ b/tests/screenshot_generator/generator.py @@ -240,7 +240,8 @@ def generate_screenshots(locale): settingsqr_data_persistent = f"settings::v1 name=English_noob_mode persistent=E xpub_qr=urca,sta denom=thr network=M qr_density=M sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E locale={locale}" settingsqr_data_not_persistent = f"settings::v1 name=Mode_Ephemeral persistent=D xpub_qr=urca,sta denom=thr network=M qr_density=M sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E locale={locale}" - # Set up screenshot-specific mocks to provide temporary data/state + # Set up mocks to provide whatever temporary data/state a particular screenshot + # might need. @contextmanager def mock_load_psbt(base64_psbt: str, seed: Seed = seed_12b): """ @@ -476,7 +477,7 @@ def generate_screenshots(locale): cur_count = screenshot_renderer.render_count # Activate the (optional) context manager for this screenshot to activate - # any specialized mocks/patches. + # any specialized mocks. with screenshot_config.mock_context_manager(): # Set up and run the target View screenshot_config.View_cls(**screenshot_config.view_kwargs).run() diff --git a/tests/screenshot_generator/utils.py b/tests/screenshot_generator/utils.py index 0998936a..83581f4b 100644 --- a/tests/screenshot_generator/utils.py +++ b/tests/screenshot_generator/utils.py @@ -83,9 +83,10 @@ def default_mock_context_manager(): @dataclass class ScreenshotConfig: """ - - mock_context_manager: Sets up temporary mock/patch context for the screenshot. - Ensures that there are no persistent state changes left over that might affect other - screenshots. + - mock_context_manager: Option to provide mocks to set up custom data or state that + the screenshot might need. The mocks will only be active during this one + screenshot's generation. Ensures that there are no persistent state changes left + over that might affect other screenshots. """ View_cls: View view_kwargs: dict = None