From f97fd3693432d953edcad6ca605524e8d0237ca7 Mon Sep 17 00:00:00 2001 From: kdmukai Date: Tue, 26 Aug 2025 16:17:25 -0500 Subject: [PATCH 1/2] Remove unnecessary: toast calls, `ScreenshotComplete` reraise --- tests/screenshot_generator/generator.py | 11 ++--------- 1 file changed, 2 insertions(+), 9 deletions(-) diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py index 0cc8bfaa..accaf9fc 100644 --- a/tests/screenshot_generator/generator.py +++ b/tests/screenshot_generator/generator.py @@ -425,15 +425,8 @@ def generate_screenshots(locale): time.sleep(0.01) - # TODO: Necessary now that the lock is in place? - # Whenever possible, clean up toast thread HERE before killing the - # main thread with ScreenshotComplete. - toast_thread.stop() - toast_thread.join() - raise ScreenshotComplete() - except ScreenshotComplete: - # Slightly hacky way to exit ScreenshotRenderer as expected - print(f"Completed {screenshot_config.screenshot_name}") + print(f"Completed {screenshot_config.screenshot_name}") + except Exception as e: # Something else went wrong from traceback import print_exc From ac194d07ad0d7a4d3771addea8bc108b97afde50 Mon Sep 17 00:00:00 2001 From: kdmukai Date: Tue, 26 Aug 2025 16:37:03 -0500 Subject: [PATCH 2/2] remove unnecessary blank line --- tests/screenshot_generator/generator.py | 1 - 1 file changed, 1 deletion(-) diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py index accaf9fc..b0b5a5d7 100644 --- a/tests/screenshot_generator/generator.py +++ b/tests/screenshot_generator/generator.py @@ -422,7 +422,6 @@ def generate_screenshots(locale): controller.activate_toast(toast_thread) while controller.toast_notification_thread.is_alive(): # Give the Toast a moment to complete its work - time.sleep(0.01) print(f"Completed {screenshot_config.screenshot_name}")