From b386caa8182e1a91d6aa3e3e5be3911c5428cb2b Mon Sep 17 00:00:00 2001 From: kdmukai <934746+kdmukai@users.noreply.github.com> Date: Fri, 13 Feb 2026 18:15:19 -0600 Subject: [PATCH 1/2] Update PR template --- .github/pull_request_template.md | 54 +++++++++++++++++++++++++------- 1 file changed, 43 insertions(+), 11 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 6a61b2dd..b3f4e0fa 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,8 +1,16 @@ ## Description -_Describe the change simply. Provide a reason for the change._ + -_Include screenshots of any new or modified screens (or at least explain why they were omitted)_ +* What is the problem or issue you're addressing here? + * Include any relevant background info, links to resources, BIPs, etc. +* What is your solution? + * Include key tech details to help reviewers understand your changes and rationale. +* Any tradeoffs to discuss, follow-up steps, etc? + + + +--- This pull request is categorized as a: @@ -12,21 +20,45 @@ This pull request is categorized as a: - [ ] Documentation - [ ] Other +--- + ## Checklist -- [ ] I’ve run `pytest` and made sure all unit tests pass before submitting the PR - -If you modified or added functionality/workflow, did you add new unit tests? - -- [ ] No, I’m a fool -- [ ] Yes +I ran `pytest` locally +- [ ] All tests passed before submitting the PR +- [ ] I couldn't run the tests - [ ] N/A -I have tested this PR on the following platforms/os: +I included screenshots of any new or modified screens +Should be part of the PR description above. +- [ ] Yes +- [ ] No (explain why they were omitted) +- [ ] N/A + + +I added or updated tests +Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests. +- [ ] Yes +- [ ] No, I’m a fool +- [ ] N/A + + +I tested this PR hands-on on the following platform(s): - [ ] Raspberry Pi OS [Manual Build](https://github.com/SeedSigner/seedsigner/blob/dev/docs/manual_installation.md) - [ ] [SeedSigner OS](https://github.com/SeedSigner/seedsigner-os) on a Pi0/Pi0W board -- [ ] Other +- [ ] Emulator -Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge. +I have reviewed these notes: +* Keep your changes limited in scope. +* If you uncover other issues or improvements along the way, ideally submit those as a separate PR. +* The more complicated the PR, the harder it is to review, test, and merge. +* We appreciate your efforts, but we're a small team of volunteers so PR review can be a very slow process. +* Please only "@" mention a contributor if their input is truly needed to enable further progress. + +- [ ] I understand + +--- + +Thank you! Please join our [Devs' Telegram group](https://t.me/seedsigner_new_devs) to get more involved. \ No newline at end of file From aa4e3293a4b1807872e57855163348d341c5b2ab Mon Sep 17 00:00:00 2001 From: kdmukai <934746+kdmukai@users.noreply.github.com> Date: Fri, 13 Feb 2026 19:57:23 -0600 Subject: [PATCH 2/2] Explicit description template; minor presentation reformatting; docs link fix --- .github/pull_request_template.md | 51 +++++++++++++++++++++++--------- 1 file changed, 37 insertions(+), 14 deletions(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index b3f4e0fa..13c1912a 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,14 +1,31 @@ ## Description - +### Problem or Issue being addressed -* What is the problem or issue you're addressing here? - * Include any relevant background info, links to resources, BIPs, etc. -* What is your solution? - * Include key tech details to help reviewers understand your changes and rationale. -* Any tradeoffs to discuss, follow-up steps, etc? + - +### Solution + + + +### Additional Information + + + +### Screenshots + + --- @@ -24,33 +41,39 @@ This pull request is categorized as a: ## Checklist -I ran `pytest` locally +#### I ran `pytest` locally - [ ] All tests passed before submitting the PR - [ ] I couldn't run the tests - [ ] N/A +--- + +#### I included screenshots of any new or modified screens -I included screenshots of any new or modified screens Should be part of the PR description above. - [ ] Yes -- [ ] No (explain why they were omitted) +- [ ] No - [ ] N/A +--- + +#### I added or updated tests -I added or updated tests Any new or altered functionality should be covered in a unit test. Any new or updated sequences require FlowTests. - [ ] Yes - [ ] No, I’m a fool - [ ] N/A +--- -I tested this PR hands-on on the following platform(s): -- [ ] Raspberry Pi OS [Manual Build](https://github.com/SeedSigner/seedsigner/blob/dev/docs/manual_installation.md) +#### I tested this PR hands-on on the following platform(s): +- [ ] Raspberry Pi OS [Manual Build](https://github.com/SeedSigner/seedsigner/blob/dev/docs/raspberry_pi_os_build_instructions.md) - [ ] [SeedSigner OS](https://github.com/SeedSigner/seedsigner-os) on a Pi0/Pi0W board - [ ] Emulator +--- -I have reviewed these notes: +#### I have reviewed these notes: * Keep your changes limited in scope. * If you uncover other issues or improvements along the way, ideally submit those as a separate PR. * The more complicated the PR, the harder it is to review, test, and merge.