From 76e404d03281f01c532b5b1c790cadb5a2d7403f Mon Sep 17 00:00:00 2001 From: Nick Klockenga Date: Mon, 14 Aug 2023 13:42:40 -0400 Subject: [PATCH 1/2] Create pull_request_template.md --- .github/pull_request_template.md | 27 +++++++++++++++++++++++++++ 1 file changed, 27 insertions(+) create mode 100644 .github/pull_request_template.md diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md new file mode 100644 index 00000000..80bb2073 --- /dev/null +++ b/.github/pull_request_template.md @@ -0,0 +1,27 @@ +## Description + +_Please enter a description and screenshots, if appropriate, of the work covered in this PR_ + +This pull request is categorized as a: + +- [ ] New feature +- [ ] Bug fix +- [ ] Code refactor +- [ ] Documentation +- [ ] Other + +## Checklist + +- [ ] I’ve run `pytest` and made sure all unit tests pass before sumbitting the PR + +If you modified or added functionality/workflow, did you add new unit tests? + +- [ ] No, I’m a fool +- [ ] Yes +- [ ] N/A + +I have tested this PR on the following platforms/os: + +- [ ] Raspberry Pi OS [Manual Build](https://github.com/SeedSigner/seedsigner/blob/dev/docs/manual_installation.md) +- [ ] [SeedSigner OS](https://github.com/SeedSigner/seedsigner-os) on a Pi0/Pi0W board +- [ ] Other From 2960c376c40f44902b3a3aab47837e9f6db319fd Mon Sep 17 00:00:00 2001 From: Nick Klockenga Date: Tue, 22 Aug 2023 21:34:15 -0400 Subject: [PATCH 2/2] Update pull_request_template.md --- .github/pull_request_template.md | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/.github/pull_request_template.md b/.github/pull_request_template.md index 80bb2073..095ea96b 100644 --- a/.github/pull_request_template.md +++ b/.github/pull_request_template.md @@ -1,6 +1,8 @@ ## Description -_Please enter a description and screenshots, if appropriate, of the work covered in this PR_ +_Describe the change simply. Provide a reason for the change._ + +_Include screenshots of any new or modified screens (or at least explain why they were omitted)_ This pull request is categorized as a: @@ -25,3 +27,6 @@ I have tested this PR on the following platforms/os: - [ ] Raspberry Pi OS [Manual Build](https://github.com/SeedSigner/seedsigner/blob/dev/docs/manual_installation.md) - [ ] [SeedSigner OS](https://github.com/SeedSigner/seedsigner-os) on a Pi0/Pi0W board - [ ] Other + + +Note: Keep your changes limited in scope; if you uncover other issues or improvements along the way, ideally submit those as a separate PR. The more complicated the PR the harder to review, test, and merge.