diff --git a/tests/screenshot_generator/generator.py b/tests/screenshot_generator/generator.py index e45373fc..9c8c8a15 100644 --- a/tests/screenshot_generator/generator.py +++ b/tests/screenshot_generator/generator.py @@ -237,8 +237,8 @@ def generate_screenshots(locale): ) add_settings_entries(SettingsConstants.VISIBILITY__HARDWARE) - settingsqr_data_persistent = f"settings::v1 name=English_noob_mode persistent=E coords=spa,spd denom=thr network=M qr_density=M xpub_export=E sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E locale={locale}" - settingsqr_data_not_persistent = f"settings::v1 name=Mode_Ephemeral persistent=D coords=spa,spd denom=thr network=M qr_density=M xpub_export=E sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E locale={locale}" + settingsqr_data_persistent = f"settings::v1 name=English_noob_mode persistent=E coords=spa,spd denom=thr network=M qr_density=M sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E locale={locale}" + settingsqr_data_not_persistent = f"settings::v1 name=Mode_Ephemeral persistent=D coords=spa,spd denom=thr network=M qr_density=M sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E locale={locale}" # Set up screenshot-specific callbacks to inject data before the View is run and # reset data after the View is run. diff --git a/tests/test_controller.py b/tests/test_controller.py index 0be99d0d..319a30ec 100644 --- a/tests/test_controller.py +++ b/tests/test_controller.py @@ -97,7 +97,6 @@ class TestController(BaseTest): # Advanced Settings defaults assert controller.settings.get_value(SettingsConstants.SETTING__NETWORK) == SettingsConstants.MAINNET assert controller.settings.get_value(SettingsConstants.SETTING__QR_DENSITY) == SettingsConstants.DENSITY__MEDIUM - assert controller.settings.get_value(SettingsConstants.SETTING__XPUB_EXPORT) == SettingsConstants.OPTION__ENABLED assert controller.settings.get_value(SettingsConstants.SETTING__SIG_TYPES) == [i for i,j in SettingsConstants.ALL_SIG_TYPES] assert controller.settings.get_value(SettingsConstants.SETTING__SCRIPT_TYPES) == [SettingsConstants.NATIVE_SEGWIT, SettingsConstants.NESTED_SEGWIT, SettingsConstants.TAPROOT] assert controller.settings.get_value(SettingsConstants.SETTING__XPUB_DETAILS) == SettingsConstants.OPTION__ENABLED diff --git a/tests/test_flows_settings.py b/tests/test_flows_settings.py index 37adf006..9a849682 100644 --- a/tests/test_flows_settings.py +++ b/tests/test_flows_settings.py @@ -78,11 +78,11 @@ class TestSettingsFlows(FlowTest): MainMenuView. """ def load_persistent_settingsqr_into_decoder(view: scan_views.ScanView): - settingsqr_data_persistent: str = "settings::v1 name=Total_noob_mode persistent=E coords=spa,spd denom=thr network=M qr_density=M xpub_export=E sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E" + settingsqr_data_persistent: str = "settings::v1 name=Total_noob_mode persistent=E coords=spa,spd denom=thr network=M qr_density=M sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E" view.decoder.add_data(settingsqr_data_persistent) def load_not_persistent_settingsqr_into_decoder(view: scan_views.ScanView): - settingsqr_data_not_persistent: str = "settings::v1 name=Ephemeral_noob_mode persistent=D coords=spa,spd denom=thr network=M qr_density=M xpub_export=E sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E" + settingsqr_data_not_persistent: str = "settings::v1 name=Ephemeral_noob_mode persistent=D coords=spa,spd denom=thr network=M qr_density=M sigs=ss scripts=nat xpub_details=E passphrase=E camera=0 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E" view.decoder.add_data(settingsqr_data_not_persistent) def _run_test(initial_setting_state: str, load_settingsqr_into_decoder: Callable, expected_setting_state: str): diff --git a/tests/test_settings.py b/tests/test_settings.py index 94ac626a..0aecfa1d 100644 --- a/tests/test_settings.py +++ b/tests/test_settings.py @@ -29,7 +29,7 @@ class TestSettings(BaseTest): return the resulting config_name and formatted settings_update_dict. """ settings_name = "Test SettingsQR" - settingsqr_data = f"""settings::v1 name={ settings_name.replace(" ", "_") } persistent=D coords=spa,spd denom=thr network=M qr_density=M xpub_export=E sigs=ss,ms scripts=nat,nes,tr xpub_details=E passphrase=E camera=180 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E""" + settingsqr_data = f"""settings::v1 name={ settings_name.replace(" ", "_") } persistent=D coords=spa,spd denom=thr network=M qr_density=M sigs=ss,ms scripts=nat,nes,tr xpub_details=E passphrase=E camera=180 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E""" # First explicitly set settings that differ from the settingsqr_data self.settings.set_value(SettingsConstants.SETTING__COMPACT_SEEDQR, SettingsConstants.OPTION__DISABLED) @@ -77,11 +77,10 @@ class TestSettings(BaseTest): def test_settingsqr_ignores_unrecognized_setting(self): """ SettingsQR parser should ignore unrecognized settings """ - settingsqr_data = "settings::v1 name=Foo favorite_food=bacon xpub_export=D" + settingsqr_data = "settings::v1 name=Foo favorite_food=bacon" config_name, settings_update_dict = Settings.parse_settingsqr(settingsqr_data) assert "favorite_food" not in settings_update_dict - assert "xpub_export" in settings_update_dict # Accepts update with no Exceptions self.settings.update(new_settings=settings_update_dict) @@ -89,15 +88,15 @@ class TestSettings(BaseTest): def test_settingsqr_fails_unrecognized_option(self): """ SettingsQR parser should fail if a settings has an unrecognized option """ - settingsqr_data = "settings::v1 name=Foo xpub_export=Yep" + settingsqr_data = "settings::v1 name=Foo passphrase=Yep" with pytest.raises(InvalidSettingsQRData) as e: Settings.parse_settingsqr(settingsqr_data) - assert "xpub_export" in str(e.value) + assert "passphrase" in str(e.value) def test_settingsqr_parses_line_break_separators(self): """ SettingsQR parser should read line breaks as acceptable separators """ - settingsqr_data = "settings::v1\nname=Foo\nsigs=ss,ms\nscripts=nat,nes,tr\nxpub_export=E\n" + settingsqr_data = "settings::v1\nname=Foo\nsigs=ss,ms\nscripts=nat,nes,tr\npassphrase=E\n" config_name, settings_update_dict = Settings.parse_settingsqr(settingsqr_data) assert len(settings_update_dict.keys()) == 3 diff --git a/tests/test_settingsqr_decoder.py b/tests/test_settingsqr_decoder.py index bb124c4f..9ec08232 100644 --- a/tests/test_settingsqr_decoder.py +++ b/tests/test_settingsqr_decoder.py @@ -9,7 +9,7 @@ class TestSettingsQRDecoder: with parsing the result. """ settings_name = "Test SettingsQR" - settings_qr_str = f"""settings::v1 name={ settings_name.replace(" ", "_") } persistent=D coords=spa,spd denom=thr network=M qr_density=M xpub_export=E sigs=ss,ms scripts=nat,nes,tr xpub_details=E passphrase=E camera=180 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E""" + settings_qr_str = f"""settings::v1 name={ settings_name.replace(" ", "_") } persistent=D coords=spa,spd denom=thr network=M qr_density=M sigs=ss,ms scripts=nat,nes,tr xpub_details=E passphrase=E camera=180 compact_seedqr=E bip85=D priv_warn=E dire_warn=E partners=E""" # Now parse the settings_qr_str decoder = DecodeQR()