 thefux
|
49d285571e
|
test: rewrite vulnerability tests as RED (assert correct behavior)
Rewrite vulnerability-documenting tests to assert CORRECT behavior
so they FAIL against current buggy main. These are TRUE TDD RED tests.
RED tests (10 failures — correct, these document live bugs):
- test_store_cashu_raises_on_db_failure (DB errors must propagate)
- test_retry_wrapper_exists (store_cashu_transaction_with_retry must exist)
- test_emergency_refund_no_try_except_pass (must not silently lose tokens)
- test_fee_payout_has_crash_guard (must have lock before pay)
- test_billing_error_must_not_hardcode_zero_cost (must not give free service)
- test_billing_error_must_release_reserved_balance (stuck funds)
- test_billing_error_catch_is_too_broad (narrow exception type)
- test_billing_error_must_log_critical (CRITICAL not ERROR)
New coverage tests (45 pass, zero regressions):
- test_coverage_base.py (17 tests): preparers, builders, injectors
- test_coverage_admin.py (11 tests): withdraw validation, slugs, auth
- test_coverage_proxy.py (13 tests): JSON parsing, model extraction
Coverage gains:
- middleware.py: 38% → 90%
- helpers.py: 52% → 60%
- proxy.py: 47% → 51%
- admin.py: 35% → 36%
Test suite: 857 pass, 10 RED failures, 14 skipped (zero regressions)
|
2026-07-17 16:05:56 +00:00 |
|