From 943e083a89c232ba666f090ea38d8f83b38eaf70 Mon Sep 17 00:00:00 2001
From: 9qeklajc <tthefux@gmail.com>
Date: Wed, 5 Aug 2026 00:49:17 +0200
Subject: [PATCH] make provider id unique

---
 ...4e8b1_never_reuse_upstream_provider_ids.py | 36 +++++++++
 routstr/core/db.py                            |  1 +
 tests/unit/test_provider_id_migration.py      | 76 +++++++++++++++++++
 3 files changed, 113 insertions(+)
 create mode 100644 migrations/versions/f2a7c9d4e8b1_never_reuse_upstream_provider_ids.py
 create mode 100644 tests/unit/test_provider_id_migration.py

diff --git a/migrations/versions/f2a7c9d4e8b1_never_reuse_upstream_provider_ids.py b/migrations/versions/f2a7c9d4e8b1_never_reuse_upstream_provider_ids.py
new file mode 100644
index 00000000..a7399661
--- /dev/null
+++ b/migrations/versions/f2a7c9d4e8b1_never_reuse_upstream_provider_ids.py
@@ -0,0 +1,36 @@
+"""never reuse upstream provider ids
+
+Revision ID: f2a7c9d4e8b1
+Revises: ecfa0d6e2a36
+Create Date: 2026-08-05 00:40:19.000000
+"""
+
+from __future__ import annotations
+
+from alembic import op
+
+revision = "f2a7c9d4e8b1"
+down_revision = "ecfa0d6e2a36"
+branch_labels = None
+depends_on = None
+
+
+def _recreate_sqlite_table(*, sqlite_autoincrement: bool) -> None:
+    with op.batch_alter_table(
+        "upstream_providers",
+        recreate="always",
+        table_kwargs={"sqlite_autoincrement": sqlite_autoincrement},
+    ):
+        pass
+
+
+def upgrade() -> None:
+    # A bare SQLite INTEGER PRIMARY KEY can reuse the highest deleted row ID.
+    # AUTOINCREMENT records a durable high-water mark in sqlite_sequence.
+    if op.get_bind().dialect.name == "sqlite":
+        _recreate_sqlite_table(sqlite_autoincrement=True)
+
+
+def downgrade() -> None:
+    if op.get_bind().dialect.name == "sqlite":
+        _recreate_sqlite_table(sqlite_autoincrement=False)
diff --git a/routstr/core/db.py b/routstr/core/db.py
index d9207d64..0a820b92 100644
--- a/routstr/core/db.py
+++ b/routstr/core/db.py
@@ -630,6 +630,7 @@ class UpstreamProviderRow(SQLModel, table=True):  # type: ignore
         UniqueConstraint(
             "base_url", "api_key", name="uq_upstream_providers_base_url_api_key"
         ),
+        {"sqlite_autoincrement": True},
     )
     id: int | None = Field(default=None, primary_key=True)
     slug: str | None = Field(
diff --git a/tests/unit/test_provider_id_migration.py b/tests/unit/test_provider_id_migration.py
new file mode 100644
index 00000000..4300810b
--- /dev/null
+++ b/tests/unit/test_provider_id_migration.py
@@ -0,0 +1,76 @@
+import os
+import sqlite3
+import subprocess
+import sys
+from pathlib import Path
+
+
+def _run_alembic(root: Path, database_url: str, command: str, revision: str) -> None:
+    env = os.environ.copy()
+    env["DATABASE_URL"] = database_url
+    subprocess.run(
+        [sys.executable, "-m", "alembic", command, revision],
+        cwd=root,
+        env=env,
+        check=True,
+        capture_output=True,
+        text=True,
+    )
+
+
+def _insert_provider(connection: sqlite3.Connection, slug: str) -> int:
+    cursor = connection.execute(
+        "INSERT INTO upstream_providers "
+        "(slug, provider_type, base_url, api_key, enabled, provider_fee) "
+        "VALUES (?, 'custom', ?, ?, 1, 1.01)",
+        (slug, f"https://{slug}.example.com", f"key-{slug}"),
+    )
+    assert cursor.lastrowid is not None
+    return cursor.lastrowid
+
+
+def test_provider_ids_are_not_reused_after_deletion(tmp_path: Path) -> None:
+    root = Path(__file__).resolve().parents[2]
+    database_path = tmp_path / "provider-id-migration.db"
+    database_url = f"sqlite+aiosqlite:///{database_path}"
+    previous_head = "ecfa0d6e2a36"
+
+    _run_alembic(root, database_url, "upgrade", previous_head)
+
+    with sqlite3.connect(database_path) as connection:
+        assert _insert_provider(connection, "first") == 1
+        assert _insert_provider(connection, "second") == 2
+        connection.execute("DELETE FROM upstream_providers WHERE id = 2")
+        assert _insert_provider(connection, "before-migration") == 2
+        connection.commit()
+
+    _run_alembic(root, database_url, "upgrade", "f2a7c9d4e8b1")
+
+    with sqlite3.connect(database_path) as connection:
+        connection.execute("DELETE FROM upstream_providers WHERE id = 2")
+        assert _insert_provider(connection, "after-migration") == 3
+        table_sql = connection.execute(
+            "SELECT sql FROM sqlite_master "
+            "WHERE type = 'table' AND name = 'upstream_providers'"
+        ).fetchone()
+
+    assert table_sql is not None
+    assert "PRIMARY KEY AUTOINCREMENT" in table_sql[0]
+
+
+def test_provider_id_migration_downgrades(tmp_path: Path) -> None:
+    root = Path(__file__).resolve().parents[2]
+    database_path = tmp_path / "provider-id-downgrade.db"
+    database_url = f"sqlite+aiosqlite:///{database_path}"
+
+    _run_alembic(root, database_url, "upgrade", "f2a7c9d4e8b1")
+    _run_alembic(root, database_url, "downgrade", "ecfa0d6e2a36")
+
+    with sqlite3.connect(database_path) as connection:
+        table_sql = connection.execute(
+            "SELECT sql FROM sqlite_master "
+            "WHERE type = 'table' AND name = 'upstream_providers'"
+        ).fetchone()
+
+    assert table_sql is not None
+    assert "AUTOINCREMENT" not in table_sql[0]