diff --git a/9f23-archive-services-setting.md b/9f23-archive-services-setting.md index bb7b073..2a0e0d8 100644 --- a/9f23-archive-services-setting.md +++ b/9f23-archive-services-setting.md @@ -49,14 +49,16 @@ We need an `archive-services` setting that: - Created tests/archive_grasp_services.rs with 4 test scenarios - Tests matching/non-matching domains, multiple services, case-insensitivity - All 39 integration tests pass (525 total tests) -- Refactored for elegance and maintainability: - - Refactored `lists_service()` to `list_services()` returning Vec - - Now extracts domains from BOTH clone URLs AND relay URLs - - Updated `extract_domain()` to handle WebSocket URLs (ws://, wss://) - - Removed `clone_url_domains()` - no longer needed - - Squashed commits into single clean implementation - - All tests pass (39 integration, 18 config, 19 events validation) -- Final commit: e573c8b (feature + test helper fix + integration tests) +- Simplified implementation via rebase: + - Rebased onto master with clean commit history + - Removed complex `matches_grasp_services()` function + - Reused existing `lists_service()` infrastructure + - Added `has_clone_url_with_case()` helper for case-insensitive matching + - Validation logic now uses existing methods: checks clone URLs only (archiving from other services) + - Removed 88 lines of unnecessary code, added 42 lines of simple helpers + - Net improvement: 46 lines less code, much cleaner +- Final commits: 25351fd (test helper fix), f911d00 (complete feature) +- All 39 integration tests pass ## Notes