2 Commits

Include renames

Author	SHA1	Message	Date
minibits-cashandClaude Opus 4.8	73610e4db8	Run the db tests against the real code, not copies of it ... The db suites hand-copied both the schema and each repo's SQL, then asserted against the copy. That proves nothing about the code the app runs, and it drifted six times across this branch while staying green — counters.test.ts was still asserting the OLD (mintUrl, keysetId) key long after it was gone, and transactionsMintUrl.test.ts kept passing while testing a function that had been deleted. Rather than make the copies track production, this removes them. The op-sqlite jest mock now backs connection.ts's driver seam with node:sqlite. connection.ts documents itself as "the single seam between the rest of the app and the native SQLite library", so mocking exactly there means tests run the production path end to end: real connection.ts (param sanitizing, result adaptation, BEGIN/COMMIT batch emulation), real instance.ts (schema creation AND the real migration runner), real repos. Net -418 lines, and no production code changed. - counters, proofReservation, onchainQuotes, meltRecovery, inFlightRequests and nut20's counter half now call Database.* directly. No copied DDL, no copied SQL. - The migration suites import their SQL from the MIGRATIONS registry. Their PRE-migration shapes stay hand-written ON PURPOSE — those are frozen history and must never track today's schema, which is the whole reason v26/v28/v29/v31 froze their column lists. That distinction is now stated in each file so the next person does not "helpfully" point them at schema.ts and reintroduce the replay bug. It found a bug on contact: walletCountersRepo allocates an index with a single `INSERT … ON CONFLICT DO UPDATE … RETURNING`. The mock routed statements by leading keyword, sent it down .run(), and the allocation failed — exactly the point, since the mirror had RE-IMPLEMENTED that statement rather than running it and so could never exercise RETURNING. Two smaller gains from using the real path: counters' rollback test now trips the real sanitizeParams guard instead of a hand-rolled NOT NULL violation, and proofReservation locks real MST Proof nodes, because the repo calls isAlive() — which only answers for an actual node, so plain objects never took production's path. Limits, recorded in the mock: Node's SQLite is not op-sqlite's build (version and compile flags may differ), so this proves our SQL and our logic, not the exact native binary — device testing still owns that. And each test FILE shares one in-memory database (instance.ts caches its connection), so suites clear tables in beforeEach rather than rebuilding. Tests: 441 pass. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-16 23:13:36 +02:00
minibits-cashandClaude Opus 4.8	9d759f83ab	Key derivation counters by keysetId; make mint URL change safe ... A mint URL is a network locator, not an identity, but it had become the de facto foreign key for most persisted state. Changing a mint's URL therefore had to rewrite every one of those references, and only proofs were ever rewritten. This removes the URL from the key space where it never belonged, and repairs the rename for what remains. Counters (the fund-losing one) mint_counters was PRIMARY KEY (mintUrl, keysetId), which asserts a key space that does not exist: NUT-13 derives from (seed, keysetId, counter), with no mint component in either path (`m/129372'/0'/{keysetIdInt}'/{counter}'` for `00` ids, HMAC-SHA256 over the id for v2 `01`). Two rows could track ONE derivation path independently, and a URL edit left the row unaddressable — hydration matched on URL, found nothing, and silently restarted the counter at 0, reusing blinded secrets the mint had already signed. Re-keyed on keysetId alone, which is sound because keyset ids are already globally unique wallet-wide, enforced at the door by isCollidingKeysetId per NUT-02. Migration 32 collapses duplicates to MAX(counter), so it HEALS wallets already split by this rather than only preventing new splits — a too-high counter skips indices, a too-low one reuses them. This also deletes code: persistCounter no longer walks getParent() for a URL, so a counter detached from its Mint now persists instead of dropping its write. Keyset collisions and NUT-02 v2 isCollidingKeysetId applied the mod-2^31-1 keysetIdInt check to every id. That integer only exists on the deprecated BIP-32 path; v2 ids derive by HMAC over the full 32 bytes and never compute it. Checking it there would reject a legitimate mint over a number nothing consumes, and re-impose v1's ~2^31 birthday bound on ids whose whole point is full-width SHA-256 resistance. The check is now gated on derivation kind; exact-id equality still always applies. Mint URL change - Validation is shared with addMint via a new normalizeMintUrl, so adding and renaming can no longer disagree. The rename previously did neither the trailing-slash strip (NUT-00 MUST) nor the https check. - Canonical form matches cashu-ts normalizeUrl (`href` then strip trailing slashes). WalletStore compares our stored string to CashuMint.mintUrl to find cached instances, so normalizing the raw input would let `https://Mint.Example` be stored while cashu-ts held `https://mint.example`: every cache lookup missing, two spellings looking like two mints. Pinned by tests asserting agreement with CashuMint.mintUrl. - The onion exemption tested `includes('.onion')`, so `http://evil.example/.onion` bought a plain-http exemption for an ordinary host. It now tests the parsed hostname. `startsWith('https')` also passed `https-evil://host`; now protocol equality. - Duplicate detection uses mintExists (normalized), not alreadyExists (literal), which missed a trailing-slash twin and let one real mint become two Mint nodes. Renaming to the URL already held is now a no-op, not an error. - hostname is recomputed; it used to keep the old mint's host forever. - transactions.mint is repointed for IN-FLIGHT rows only. That column means two things by status: for a terminal row it is a historical record of where the payment happened, but for an open one it is a live pointer the wallet still calls (checkLightningMintQuote, checkLightningMeltQuote/checkOnchainMeltQuote, findByUrl on revert/receive). Stale, it strands a paid topup at a dead URL forever. One UPDATE, so the status test cannot straddle a transition. - ProofsStore.updateMintUrl now writes SQLite before memory; the reverse left the UI showing a balance the database never received. Still URL-keyed, and documented on setMintUrl: onchain mint quotes, in-flight requests, melt recovery and open reservations. Renaming a mint with any of those outstanding still strands them. They need a stable mint id, which is the next step. Tests: 413 pass. The two new v2 collision tests fail against the previous code and pass here, while the v1 cases pass in both. counters.test.ts mirrored the production SQL by hand and so had asserted the old key — including a test that two mints sharing a keyset id keep independent counters, exactly the unsound behaviour removed here. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com>	2026-07-16 17:41:02 +02:00