mirror of
https://github.com/jmcorgan/fips.git
synced 2026-10-05 19:18:25 +00:00
Johnathan Corgan
32bf476660
A tree announce was counted as delivered once the transport accepted it, so a lost datagram left the peer on our old tree position until the periodic re-broadcast up to a minute later, and indefinitely on a node with a single peer, which has no periodic re-broadcast. Meanwhile the peer could leave destinations out of discovery or route toward them by stale coordinates. The tree state now keeps, per peer, the tree announce still awaiting confirmation from the link's receiver reports, using the same delivery check as filter announces. The declaration sequence is the lineage: a new sequence refills the resend budgets, while a resend or periodic re-broadcast of the same declaration spends from them. The tracking is dropped with the peer. The node resends on a reported loss, and once after 30 s when the reports cannot confirm the announce. Per declaration and session it resends at most once unchecked and three times on loss, and at most six times a minute per peer. The resend is an ordinary announce of the current declaration through the rate-limited send path, and the "Sent TreeAnnounce" trace line now carries the declaration sequence. The node tests run on a converged line with every role read from the converged tree, and share the loopback MMP, loss and rekey helpers of the filter announce tests, now generalised to node indices. The Ethernet mesh scenario's 60 s delivery window no longer sits at the ordinary recovery bound, since tree and filter announces lost to a link flap are now resent within seconds of the link returning, or after about 30 s when the reports cannot confirm them. A comment beside the assertion says so, so a red there is investigated rather than expected.