mirror of
https://github.com/jmcorgan/fips.git
synced 2026-10-05 11:08:25 +00:00
The released .deb installs cleanly on Debian 12 and Ubuntu 22.04 and the daemon then cannot start, with the loader reporting GLIBC_2.39 not found. Three binaries are affected, fips, fipstop and fips-gateway; fipsctl runs, which is why it stayed quiet, since an install checked by running fipsctl gets a clean answer while the daemon is dead. It is not a v0.5.0 regression: every release artifact from v0.3.0 onward carries the same floor and the same unversioned dependency. The cause is the build machine. Rust's standard library references pidfd_spawnp and pidfd_getpid as weak undefined symbols behind a runtime check, so a binary should fall back where the C library lacks them. Linking against a C library that has them records a hard version dependency instead, and the loader refuses the image on that entry alone. No Rust changed here. One script now produces the Linux artifacts. It builds in a container pinned to the oldest distribution still supported for free by its distributor, named with the floor in packaging/build-floor.env, and runs the floor check on the package it produced, so every producer is gated rather than one workflow. The floor guard reads readelf's Version needs section: the obvious objdump formulation returns 2.2.5 for the shipped fips and would have passed every affected release. The script prints the package path as the only thing on its stdout, which is what lets a caller take it without parsing, and it takes --features. Both required care. The container's own stdout reaches the caller, so the build runs with its output on stderr; without that, a caller using a plain command substitution captures four lines of build chatter along with the path. And a feature build must keep the +<features> marker that distinguishes it from the default build of the same commit, or dpkg sees two packages at one version and a revert silently no-ops. The version is derived on the host, because the image has no git and the source is mounted read-only, so build-deb.sh now applies that marker to an explicit version as well as to one it derives. Both runners now build once through that script and install the artifact. The five deb-install legs previously built their own package each, so one CI run performed five complete release builds and four were waste; they now live in a job of their own that downloads one built package, which also stops the rest of the integration matrix waiting on it. The parity guard read one hardcoded job and now sweeps every job's matrix. The release workflow builds both architectures through the same script, and the systemd tarball takes its binaries out of that package instead of from a second, unchecked set on the runner, then is floor-checked after the strip. Cargo.toml derives the dependency with $auto rather than stating a bare libc6 that nothing can fail. Note the ordering this implies for any pipeline that builds on a current distribution: until it builds through this script, its packages will declare libc6 (>= 2.39). Measured: the container build produces four binaries at 2.34, and one artifact passes all five distributions, 95 checks, in about two minutes. The floor check fails the released 0.5.0 package on three binaries and passes this one. A profiling build produces fips_0.5.1~dev+git<date>.<sha>+profiling-1_amd64.deb.
190 lines
7.3 KiB
Bash
Executable File
190 lines
7.3 KiB
Bash
Executable File
#!/usr/bin/env bash
|
|
# Build a .deb package for FIPS using cargo-deb.
|
|
#
|
|
# Usage: ./build-deb.sh [--target <triple>] [--version <version>] [--no-build]
|
|
# [--features <list>]
|
|
#
|
|
# Prerequisites: cargo-deb (install with: cargo install cargo-deb)
|
|
# Output: deploy/fips_<version>_<arch>.deb
|
|
|
|
set -euo pipefail
|
|
|
|
SCRIPT_DIR="$(cd "$(dirname "$0")" && pwd)"
|
|
PROJECT_ROOT="${SCRIPT_DIR}/../.."
|
|
|
|
usage() {
|
|
cat <<'EOF'
|
|
Usage: packaging/debian/build-deb.sh [options]
|
|
|
|
Options:
|
|
--target <triple> Rust target triple to build/package
|
|
--version <version> Override Debian package version
|
|
--no-build Package existing binaries without running cargo build
|
|
--features <list> Cargo features to build with (comma-separated). Marks the
|
|
auto-derived Version so the package is distinguishable
|
|
from a default build of the same commit.
|
|
--output-dir <dir> Where to put the finished .deb. Defaults to deploy/ under
|
|
the project root. Exists so the container build can write
|
|
to a mount and leave the source tree read-only.
|
|
-h, --help Show this help
|
|
EOF
|
|
}
|
|
|
|
TARGET_TRIPLE=""
|
|
VERSION_OVERRIDE=""
|
|
NO_BUILD=0
|
|
FEATURES=""
|
|
DEST_DIR=""
|
|
|
|
while [[ $# -gt 0 ]]; do
|
|
case "$1" in
|
|
--target)
|
|
TARGET_TRIPLE="${2:?missing value for --target}"
|
|
shift 2
|
|
;;
|
|
--version)
|
|
VERSION_OVERRIDE="${2:?missing value for --version}"
|
|
shift 2
|
|
;;
|
|
--no-build)
|
|
NO_BUILD=1
|
|
shift
|
|
;;
|
|
--features)
|
|
FEATURES="${2:?missing value for --features}"
|
|
shift 2
|
|
;;
|
|
--output-dir)
|
|
DEST_DIR="${2:?missing value for --output-dir}"
|
|
shift 2
|
|
;;
|
|
-h|--help)
|
|
usage
|
|
exit 0
|
|
;;
|
|
*)
|
|
echo "Unknown option: $1" >&2
|
|
usage >&2
|
|
exit 1
|
|
;;
|
|
esac
|
|
done
|
|
|
|
# A feature build that skips the build step would stamp a feature-marked Version
|
|
# onto whatever binaries already sit in target/, which is the one outcome the
|
|
# marking exists to prevent. Refuse rather than emit a package that misdescribes
|
|
# itself.
|
|
if [[ -n "${FEATURES}" && "${NO_BUILD}" -eq 1 ]]; then
|
|
echo "--features cannot be combined with --no-build: the features would not" >&2
|
|
echo "reach the binaries, but the Version would claim they had." >&2
|
|
exit 1
|
|
fi
|
|
|
|
cd "${PROJECT_ROOT}"
|
|
|
|
# Ensure cargo-deb is available
|
|
if ! command -v cargo-deb &>/dev/null; then
|
|
echo "cargo-deb not found. Install with: cargo install cargo-deb" >&2
|
|
exit 1
|
|
fi
|
|
|
|
# Derive SOURCE_DATE_EPOCH from git if not already set (reproducible builds)
|
|
if [ -z "${SOURCE_DATE_EPOCH:-}" ]; then
|
|
export SOURCE_DATE_EPOCH=$(git log -1 --format=%ct)
|
|
fi
|
|
|
|
# Auto-derive a per-commit Debian Version for dev builds so apt-based
|
|
# upgrade detection (`ansible.builtin.apt: deb:`, `apt install ./*.deb`)
|
|
# does not silently no-op when one dev .deb is installed on top of another.
|
|
# Tagged release builds (Cargo.toml version without "-dev") keep the
|
|
# clean upstream version. Operator override via --version still wins.
|
|
if [[ -z "${VERSION_OVERRIDE}" ]]; then
|
|
CRATE_VERSION=$(awk -F'"' '/^version = /{print $2; exit}' Cargo.toml)
|
|
if [[ "${CRATE_VERSION}" == *-dev ]]; then
|
|
BASE_VERSION="${CRATE_VERSION%-dev}"
|
|
GIT_DATE=$(git log -1 --format=%cs | tr -d '-')
|
|
GIT_SHA=$(git rev-parse --short HEAD)
|
|
DIRTY_SUFFIX=""
|
|
if [[ -n "$(git status --porcelain 2>/dev/null)" ]]; then
|
|
DIRTY_SUFFIX=".dirty"
|
|
fi
|
|
# A feature build of a given commit is a different package from the
|
|
# default build of that same commit, but nothing else in this version
|
|
# says so: the crate version, the date and the sha are all identical.
|
|
# Without a marker the two are byte-identical versions, so installing
|
|
# one over the other is an apt no-op (the very failure the per-commit
|
|
# version above exists to prevent) and the node offers no way to tell
|
|
# which one it is running. Underscores and commas are not legal in a
|
|
# Debian version, so the feature list is folded to dots.
|
|
FEATURE_SUFFIX=""
|
|
if [[ -n "${FEATURES}" ]]; then
|
|
FEATURE_SUFFIX="+$(printf '%s' "${FEATURES}" | tr -c 'a-zA-Z0-9.' '.')"
|
|
fi
|
|
# Debian Version: <upstream>~dev+git<YYYYMMDD>.<sha>[.dirty][+<features>]-1
|
|
# The "~" makes every dev build sort BEFORE the eventual tagged
|
|
# release; the date+sha makes consecutive dev builds compare as
|
|
# different versions; the trailing "-1" is the Debian revision.
|
|
# The feature suffix sorts ABOVE the unsuffixed build, so installing a
|
|
# feature build is an upgrade and reverting to the default build is a
|
|
# downgrade — which apt refuses without being told to, and `dpkg -i`
|
|
# performs. Revert with `dpkg -i`, not `apt install`.
|
|
VERSION_OVERRIDE="${BASE_VERSION}~dev+git${GIT_DATE}.${GIT_SHA}${DIRTY_SUFFIX}${FEATURE_SUFFIX}-1"
|
|
echo "Auto-derived dev Version: ${VERSION_OVERRIDE}"
|
|
fi
|
|
elif [[ -n "${FEATURES}" ]]; then
|
|
# An explicit version needs the same marker for the same reason, and it is
|
|
# the only way a caller that cannot derive the version here can get one.
|
|
# The container build is that caller: it derives the version on the host
|
|
# because the image has no git, and the source is mounted read-only from a
|
|
# worktree whose .git is a file pointing outside the mount.
|
|
if [[ "${VERSION_OVERRIDE}" == *"+$(printf '%s' "${FEATURES}" | tr -c 'a-zA-Z0-9.' '.')"* ]]; then
|
|
: # already marked by the caller
|
|
elif [[ "${VERSION_OVERRIDE}" == *-* ]]; then
|
|
# Split off the Debian revision so the marker lands on the upstream part.
|
|
VERSION_OVERRIDE="${VERSION_OVERRIDE%-*}+$(printf '%s' "${FEATURES}" | tr -c 'a-zA-Z0-9.' '.')-${VERSION_OVERRIDE##*-}"
|
|
else
|
|
VERSION_OVERRIDE="${VERSION_OVERRIDE}+$(printf '%s' "${FEATURES}" | tr -c 'a-zA-Z0-9.' '.')"
|
|
fi
|
|
echo "Feature-marked Version: ${VERSION_OVERRIDE}"
|
|
fi
|
|
|
|
# Build the .deb package
|
|
echo "Building .deb package..."
|
|
OUTPUT_DIR="$(mktemp -d)"
|
|
trap 'rm -rf "${OUTPUT_DIR}"' EXIT
|
|
|
|
cargo_args=(deb --output "${OUTPUT_DIR}")
|
|
if [[ -n "${TARGET_TRIPLE}" ]]; then
|
|
cargo_args+=(--target "${TARGET_TRIPLE}")
|
|
fi
|
|
if [[ -n "${VERSION_OVERRIDE}" ]]; then
|
|
cargo_args+=(--deb-version "${VERSION_OVERRIDE}")
|
|
fi
|
|
if [[ "${NO_BUILD}" -eq 1 ]]; then
|
|
cargo_args+=(--no-build)
|
|
fi
|
|
if [[ -n "${FEATURES}" ]]; then
|
|
cargo_args+=(--features "${FEATURES}")
|
|
fi
|
|
cargo "${cargo_args[@]}"
|
|
|
|
# Move output to the requested directory, or deploy/ by default. Note the
|
|
# distinction from OUTPUT_DIR above, which is cargo-deb's temporary staging
|
|
# directory and is removed by the EXIT trap.
|
|
: "${DEST_DIR:=deploy}"
|
|
mkdir -p "${DEST_DIR}"
|
|
DEB_FILE=$(find "${OUTPUT_DIR}" -maxdepth 1 -name '*.deb' -printf '%T@ %p\n' | sort -rn | head -1 | cut -d' ' -f2)
|
|
|
|
if [ -z "${DEB_FILE}" ]; then
|
|
echo "Error: No .deb file found in ${OUTPUT_DIR}" >&2
|
|
exit 1
|
|
fi
|
|
|
|
cp "${DEB_FILE}" "${DEST_DIR}/"
|
|
BASENAME=$(basename "${DEB_FILE}")
|
|
echo "Package built: ${DEST_DIR}/${BASENAME}"
|
|
echo ""
|
|
echo "Install with: sudo dpkg -i ${DEST_DIR}/${BASENAME}"
|
|
echo "Remove with: sudo dpkg -r fips"
|
|
echo "Purge with: sudo dpkg -P fips (removes config and identity keys)"
|