3 Commits

Include renames

Author	SHA1	Message	Date
Johnathan Corgan	77ed64bb88	Compute every peer's outgoing bloom filter in one sweep ... Each peer must be sent the union of all other peers' inbound filters, excluding its own contribution. Building that per recipient rebuilt the whole peer-filter map and re-ORed it once for every peer, so a tick that announced to R peers did R kilobyte-scale map builds and R by T merges. At 240 peers this was 20.6 ms per tick, roughly half the tick body, and it was steady work rather than a tail: the per-interval maximum had a median of 34.5 ms. Replace it with a prefix and suffix union sweep that produces every target's filter in one pass, T merges instead of R by T. The packet path gets the same treatment, since marking changed peers had the identical shape once per inbound announce. The result is exactly equal, not approximately. Merging is a bytewise OR, so regrouping the unions cannot change the outcome, and a filter whose size does not match is rejected before any byte is touched, at every merge site in both the old and new arrangement. Every accumulator here is default-sized, so an odd-sized peer filter is skipped in the new code exactly where it was skipped in the old. Cadence, the debounce, the sequence rule and the fill-ratio cap are untouched. A sequence number is still drawn after the debounce re-check and before encoding, so a suppressed peer still consumes none and an encode failure still burns one. Known trade-off, measured rather than assumed: the sweep does its full O(T) work regardless of how many peers are ready, so a tick that announces to only one or two peers now costs about twice what it did. Break-even is around three ready peers, and the saving above that grows without bound. The marking path is a pure win, since it always targets every peer.	2026-07-29 01:45:12 +00:00
Johnathan Corgan	5fc2359432	fipstop: TUI overhaul with render-snapshot harness and navigation model ... Reworks the fipstop TUI across its rendering, the control read surface it draws from, and its interaction model, on a machine-verified base. Test infrastructure: - Add a ratatui TestBackend snapshot harness (testkit + snapshots modules) that renders any ui::draw_* into an in-memory Buffer from canned show_* JSON and asserts the text grid plus per-cell style. Layout, columns, alignment, labels, grouping, and colour are now checkable under cargo test; every render below ships a snapshot. Control read surface (each new field emitted byte-identically on the live and off-loop builders, published once from the tick, with schema fixtures regenerated and the parity asserts holding): - show_status: effective persistence (persistent || nsec.is_some()); root and is_root; and a per-configured-transport-type peer-count map in which idle-but-configured types stay visible at zero. - show_peers: per-peer effective_depth (depth + link_cost, the value evaluate_parent ranks on), null when unmeasured or coordless so fipstop never recomputes it. - show_tree: root_npub, resolved once daemon-side (self when root, an attested peer npub, or an identity-cache hit). - show_bloom: the last-actually-sent uptree filter fill ratio and subtree estimate, null for a root or before the first announce. - show_mmp: session-layer srtt, loss, and etx trend labels. Rendering: - Display a 6-byte non-UTF-8 TransportAddr as a colon-separated MAC at the type layer, so daemon logs, fipsctl, and JSON consumers all benefit; non-6-byte payloads stay bare hex. - Right-justify the Bloom Peer Filters numerics into aligned fixed-width columns, render the Routing panes through a kv_lines helper that shares one value column across a key-value group, and right-justify the Graphs by-peer summary columns. - Truncate an over-long peer name (the npub shown when no friendly name exists) in the Tree, Bloom, and MMP peer lists so it no longer runs into the next column. - Group the Peers table by role (parent, then STP children, then other) and render it as a full grouped view with styled group labels and blank separators; the selection stays a peer index and the cursor only ever lands on a peer row. Apply the same role grouping to the Tree and Bloom peer lists, joining each peer's role from the peers view by node address. - Show min in the Graphs plot titles, rest a steady non-zero metric on the baseline as a row of dots, render a genuine zero as an empty plot, and keep a distinct no-data placeholder. - Replace the metric-by-peer grid, which squeezed plots to nothing once peers overflowed, with a master/detail Graphs view: a scrollable per-peer summary list that expands (Enter) to a full-pane btop plot, with up/down to flip peer, n/N to switch statistic, m to cycle mode, and Esc to return. - Put inline colored trend arrows on the Link and Session MMP values (drawn only on a rising or falling trend, with a fixed blank slot when stable so the value columns stay aligned), via a shared helper. - Cycle column sorting on the Link MMP, Session MMP, and Graphs by-peer tables (one key cycles the active column, another toggles direction), with the active column marked in each table's header. - Render the new daemon-surfaced fields: the dashboard root line (a self-is-root marker, otherwise a truncated root hex), a transports-by-type line, and an "approx. mesh estimate" line; an effective_depth column and lines on the Peers, peer-detail, and Tree sites from the single daemon derivation, showing a dash placeholder when unmeasured rather than a misleading zero; the full Tree root hex plus an Npub line; and the Bloom uptree fill and subtree-estimate lines. Interaction model: - Add a declarative keybinding registry keyed by (Tab, UiMode) that both the context footer and the ? help overlay render from, so the two cannot drift; a test asserts every registry key has a dispatch handler. - Add a modal ? help overlay, and a context-aware footer that shows the current state's actions first, drops global hints when the terminal is narrow, and always keeps a Help affordance as the overflow path. - Generalize per-pane focus and scroll state on App, wired across the Tree, Filters, Routing, and MMP tabs (f cycles pane focus and the focused pane scrolls instead of clipping its overflow); on the MMP tab the column sort acts on the focused pane. Esc deselects the active row when no detail is open (detail-close still takes priority). - Add a Del-disconnect confirmation modal naming the peer, the only state-mutating action, issuing the control-socket disconnect on confirm and noting that the peer stays disconnected until manually reconnected.	2026-06-12 23:05:58 +00:00
Johnathan Corgan	b8a1f322c2	Module reorganization and clippy cleanup ... Move single-consumer modules into node/: - rate_limit.rs, wire.rs, dns.rs — exclusively used by node subsystem - Reduces top-level lib.rs from 16 to 13 modules Split large files into focused subdirectories: - noise.rs (1475 lines) → noise/{mod, handshake, session, replay, tests}.rs - tree.rs (1479 lines) → tree/{mod, coordinate, declaration, state, tests}.rs - bloom.rs (849 lines) → bloom/{mod, filter, state, tests}.rs - All public APIs re-exported from mod.rs, no external import changes Remove unused rate_limit defaults: - HANDSHAKE_TIMEOUT_SECS, MAX_PENDING_INBOUND constants - Default constructor eliminated in favor of with_params() taking config values Fix all clippy warnings across codebase: - Remove .clone() on Copy types, collapse nested ifs, replace match-return-None with ?, remove/gate unused code, fix loop indexing, remove unnecessary casts - Box large PeerSlot enum variants to reduce size disparity - cargo clippy --all-targets now reports zero warnings	2026-02-15 15:07:42 +00:00