From c560ba0f07ae594e2b02c3beb17a4f16a493b156 Mon Sep 17 00:00:00 2001 From: Johnathan Corgan Date: Wed, 23 Sep 2026 04:12:13 +0000 Subject: [PATCH] Correct the reason given for disabling the MIPS OpenWrt builds The comment said fips's own atomics already use portable_atomic, so only the Nostr relay pool stood in the way. That is true only of the transport stats modules; the node metrics, the profiler and other modules still use std's AtomicU64, which 32-bit MIPS lacks. Say so, and note that the nightly matrix entries would also need -Zbuild-std, which the build step does not pass. --- .github/workflows/package-openwrt.yml | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/.github/workflows/package-openwrt.yml b/.github/workflows/package-openwrt.yml index e54e8597..c9945dd6 100644 --- a/.github/workflows/package-openwrt.yml +++ b/.github/workflows/package-openwrt.yml @@ -86,9 +86,11 @@ jobs: rust_target: aarch64-unknown-linux-musl rust_channel: stable # MT3000, MT6000, Flint 2, RPi 3/4/5 - # MIPS disabled: nostr-relay-pool 0.44 uses std::sync::atomic::AtomicU64 - # directly (fips's own atomics already use portable_atomic). Re-enable - # once an upstream portable-atomic patch lands (or via [patch.crates-io]). + # MIPS disabled: 32-bit MIPS has no 64-bit atomics, and both + # nostr-relay-pool 0.44 and fips itself (outside the transport stats + # modules) use std::sync::atomic::AtomicU64. Re-enabling needs both on + # portable_atomic, and the nightly entries below also need -Zbuild-std, + # which the build step does not pass. # - build_arch: mipsel # openwrt_arch: mipsel_24kc # rust_target: mipsel-unknown-linux-musl