From 5dfa571908cad62ffd0f60624f01c54e8b47e242 Mon Sep 17 00:00:00 2001 From: Johnathan Corgan Date: Tue, 14 Jul 2026 23:23:54 +0000 Subject: [PATCH] node: pin promote-failure warnings to the handshake tracing target The two promote-failure warn! sites in the peer-action executor emit under this module's own tracing target rather than the handshake target the rest of the establish-path logging uses. Pin both (outbound "Failed to promote connection" and inbound "Failed to promote inbound connection") to fips::node::handlers::handshake, matching the sibling max-peers reject log and keeping all establish-path diagnostics grouped under one target regardless of which module physically emits them. --- src/node/dataplane/peer_actions.rs | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-) diff --git a/src/node/dataplane/peer_actions.rs b/src/node/dataplane/peer_actions.rs index c0011db..916fcc1 100644 --- a/src/node/dataplane/peer_actions.rs +++ b/src/node/dataplane/peer_actions.rs @@ -299,7 +299,12 @@ impl Node { // did not exist pre-refactor, so removing the just- // inserted machine on failure is neutral vs old and // prevents a leak. - warn!(link_id = %promote_link, error = %e, "Failed to promote connection"); + warn!( + target: "fips::node::handlers::handshake", + link_id = %promote_link, + error = %e, + "Failed to promote connection" + ); self.stats_mut().record_reject(RejectReason::Handshake( HandshakeReject::BadState, )); @@ -309,7 +314,12 @@ impl Node { // + reverse map, free our index, discard the machine, // and record the reject. Restored pre-refactor inbound // promote-failure warn! (`handle_msg1` L757). - warn!(link_id = %promote_link, error = %e, "Failed to promote inbound connection"); + warn!( + target: "fips::node::handlers::handshake", + link_id = %promote_link, + error = %e, + "Failed to promote inbound connection" + ); self.remove_link(&promote_link); if let Some(idx) = ambient.our_index { let _ = self.index_allocator.free(idx);