From c2fb12d99728deab23c61c61574873a21ea787b3 Mon Sep 17 00:00:00 2001 From: Johnathan Corgan Date: Mon, 8 Jun 2026 20:26:05 +0000 Subject: [PATCH] sidecar test: clear node-a peer env so it does not join the public mesh The sidecar chain test intends node-a to be a standalone root ("node-a: no outbound peers"), but started node-a without clearing FIPS_PEER_*, so it inherited the external peer default from testing/sidecar/.env (a real public mesh node, test-us01.fips.network) and auto-connected to the live mesh. The whole a-b-c chain then attached under an external root, inflating tree depth and breaking test isolation; this also produced spurious multi-hop failures. Set FIPS_PEER_NPUB/FIPS_PEER_ADDR empty for node-a, matching how node-b and node-c already get explicit inline peers, so the suite is hermetic regardless of the .env default. Validated against the unmodified .env: node-a comes up with a single link to node-b, no external attachment, multi-hop passes 18/18. --- testing/sidecar/scripts/test-sidecar.sh | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/testing/sidecar/scripts/test-sidecar.sh b/testing/sidecar/scripts/test-sidecar.sh index 7952c2d..a5cbf5b 100755 --- a/testing/sidecar/scripts/test-sidecar.sh +++ b/testing/sidecar/scripts/test-sidecar.sh @@ -74,7 +74,13 @@ fi # node-c: peers with B (end node) log "Starting node-a (no peers, creates network)..." +# node-a is the root: explicitly clear FIPS_PEER_* so it does not inherit the +# external peer default from .env (which points at a real public mesh node). +# Without this, node-a auto-connects to the live mesh and the chain attaches +# under an external root, inflating tree depth and breaking isolation. FIPS_NSEC="$NODE_A_NSEC" \ +FIPS_PEER_NPUB="" \ +FIPS_PEER_ADDR="" \ FIPS_NETWORK="$NETWORK_NAME" \ FIPS_SUBNET="$SUBNET" \ FIPS_IPV4="$NODE_A_IP" \