mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-10-05 19:28:25 +00:00
davotoula
42c96bf8fc
The [ExtraTranslation] failure that took main red in 1ce583ec92 was not documented anywhere. amethyst/src/main/res/CLAUDE.md and the find-missing-translations skill both mention the lint rule, but only inside one narrow case (converting a <string> to <plurals>). Neither stated the general rule: removing or renaming a key in the default values/strings.xml orphans every locale entry that still declares it. Nor would running lint have caught it in practice. The only pre-push gate is pre-push-spotless.sh, which runs spotlessApply and nothing else, and :amethyst:lintFdroidBenchmark takes ~19 minutes on a warm daemon, so it is not a per-commit check. Add both halves: - amethyst/src/main/res/CLAUDE.md gains a "Renaming or removing a string key" section stating the same-commit rule and why Crowdin is not a cleanup step CI waits for. The trap is that Crowdin is *partly* reliable — it cleaned 32 of 47 locales — so the tree looks correct in whichever files you open. Retitled the file (it is no longer plural-only) and marked the existing sections as the plural-specific ones they always were. - orphan_strings_check.py scans every locale's resource names against its tree's default values/, across both Crowdin-managed resource systems: the Android res trees and the commons Compose-Multiplatform catalog. 0.17s against the full repo. pre-push-orphan-strings.sh wraps it as a PreToolUse gate on git push / create_pull_request, reusing the shell-tokenizing push-detection from pre-push-spotless.sh so "push" inside a commit message is not mistaken for the subcommand. - find-missing-translations gains a Common Mistakes entry pointing at both. Verified: clean on the current tree; exit 2 listing the orphans when route_video is reintroduced in two locales and a retired key is seeded in the Compose catalog; gate fires on git push and create_pull_request, stays quiet on a commit whose message contains "push" and on non-Bash tools.
38 lines
1.5 KiB
Bash
Executable File
38 lines
1.5 KiB
Bash
Executable File
#!/bin/bash
|
|
# PreToolUse gate: no locale string may outlive its default-locale key.
|
|
#
|
|
# Fires on `git push` (Bash tool) and on the create_pull_request MCP tool.
|
|
# Delegates to orphan_strings_check.py, which compares every
|
|
# `values-<locale>/*.xml` resource name against the union of names declared in
|
|
# that tree's default `values/*.xml`. Anything present in a locale but absent
|
|
# from the default is an orphan: in an Android res tree Android lint reports it
|
|
# as an [ExtraTranslation] ERROR, which aborts `:amethyst:lint<Variant>` and
|
|
# therefore the whole `test-and-build-android` CI job.
|
|
#
|
|
# Why a dedicated hook instead of "just run lint": `:amethyst:lintFdroidBenchmark`
|
|
# takes ~19 minutes on a warm daemon, so nobody runs it per-commit. This check is
|
|
# a directory scan and finishes in well under a second.
|
|
#
|
|
# Run the scan by hand any time with: .claude/hooks/orphan_strings_check.py
|
|
set -uo pipefail
|
|
|
|
hook_dir="$(cd "$(dirname "$0")" && pwd)"
|
|
cd "${CLAUDE_PROJECT_DIR:-.}" || exit 0
|
|
|
|
# --- Is this call a push/PR boundary? ---
|
|
payload="$(cat)"
|
|
|
|
# Cheap pure-bash pre-filter before paying for a python spawn. The gate below
|
|
# can only answer "yes" for a payload containing "push" (a git push command) or
|
|
# "pull_request" (the create_pull_request MCP tool), so anything else is a
|
|
# guaranteed no. This hook runs on EVERY Bash tool call, and the spawn it skips
|
|
# costs ~35ms each time.
|
|
case "$payload" in
|
|
*push*|*pull_request*) ;;
|
|
*) exit 0 ;;
|
|
esac
|
|
|
|
printf '%s' "$payload" | python3 "$hook_dir/lib/git_push_gate.py" || exit 0
|
|
|
|
exec python3 "$hook_dir/orphan_strings_check.py"
|