mirror of
https://github.com/vitorpamplona/amethyst.git
synced 2026-08-09 08:04:45 +00:00
Two regressions from this session's audit batch: 1. Bottom nav bar reset. Adding stable @SerialName discriminators to BottomBarEntry changed the persisted polymorphic "type" value from the fully-qualified class name to "builtIn"/"favorite", so configs written by an earlier build no longer decoded — and the fallback returned an empty list, blanking the bar. decodeBottomBarItems now migrates the old fully-qualified discriminators to the short names (recovering the user's customized bar), and any unrecognizable value falls back to the defaults instead of empty. Locked with BottomBarEntrySerializationTest. 2. Pull-down sheet interfered with page taps. The expanded top sheet is a full-width drawer with no way to dismiss except the grabber, so it sat over the page. Hoist its expanded state into EmbeddedTabLayer (reset per tab) and draw a full-area dismiss scrim behind the open sheet; collapsed, only the small grabber is interactive and page taps pass through. Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MgMpRcWj6y82LxLiwcuzmN