Files
amethyst/desktopApp/src
Claude 1e04f7b06e fix(commons): audit follow-ups for the shared relayClient layer
Review findings on the three migration commits, all verified:

- The shared feed-floor watcher sampled at 5 s for every feed, but the
  video swipe feed used 1 s before the refactor, so paging older videos
  waited up to five times longer. The interval is now a `floorSampleMs`
  override and Video keeps its 1 s cadence.
- `endSub` cancelled the watcher jobs but never dropped the `userJobMap`
  entry, leaving a cancelled job list per account ever subscribed on every
  app-lifetime assembler. It now removes the entry.
- `DesktopLocalCache.consume(nip19)` was a copy of the Android body. The
  NIP-19 seeding is now one default on `ICacheProvider`, built only from
  interface members, with a single `consumeEmbedded(event)` hook for the
  `nembed` branch (Android verifies via `justConsume`, Desktop via its
  `consume(event, relay)`). The default uses `checkGetOrCreateNote`, so an
  invalid id yields no placeholder instead of an exception.
- `allRelayGroupChannels()` dumped the group cache through a predicate that
  always returned true; it now snapshots `values()`.
- The music/podcast kind lists go back to `internal`: their only callers
  moved into commons with the dispatchers.

Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01J836W9ZjSUJUQ1d23TpiJo
2026-09-05 20:59:34 +00:00
..