mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-10-05 19:28:25 +00:00

Files

T

Claude 8187028c35 fix: audit findings in the code moved to commons

Pre-existing bugs found while auditing the moved files, none introduced
by the move:

- showAmount/showAmountInteger rounded half-even (Kotlin's BigDecimal
  div) so 12,500 read "12k", and picked the unit before rounding so
  999,500 read "1000k".
- AgentWorkBoard.merge ordered every band by upvotes, not just the queue.
- SuspendableConfirmation could resume twice (tap + dismiss) and left a
  dead dialog when the upload was cancelled.
- TorDialogViewModel.save rejected Internal/Off over a hidden, invalid
  port, and accepted out-of-range ports for External.
- ExpandingCirclesAnimation ran an infinite transition whenever the
  composer was open; the circles now exist only while recording and
  animate in the draw phase.
- DebouncedPublisher.flush cancelled and restarted a publish already in
  flight (a second signer request).
- RelayFeedViewModel read the wrong note for the DM list's first
  emission, and compared the flow instead of its value.
- ScheduledFlag built a DateFormat per composition; Cashu discovery
  progress could step backwards; Desktop's chess view model kept
  polling after an account switch replaced it.

New tests: ZapFormatterTest, SuspendableConfirmationTest,
TorDialogViewModelTest, and a DebouncedPublisher case.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01BkG4KTqmnprUK9BAcwAyc8

2026-09-27 14:18:07 +00:00

README.md

commons plans

Audited 2026-06-30 (+ 2026-09-12 split entry, 2026-09-27 migration entries).

In progress

Plan	Summary
2026-05-04-custom-feeds-plan.md	Custom feed creation/discovery/management for Desktop; core model + builder + kind 31890 + desktop UI shipped, but relay-filter layer, DVM marketplace, kind 10090 sync, and list resolution still pending.
2026-05-06-nest-subscription-manager-extraction.md	Split the per-speaker subscription state machine out of `NestViewModel`; only the `ActiveSubscription` stepping-stone is extracted so far.
2026-08-30-commons-migration-sweep.md	The running tracker for moving `amethyst/` code into `commons`/`commonsUI`: waves, what moved each round, what stays and why. `LocalCache` has moved; retiring `DesktopLocalCache` (Wave 2 part B) and the `AccountViewModel` hub composables are next.
2026-05-30-amethyst-to-commons-migration.md	The original roadmap for the same move; superseded in practice by the sweep tracker above.

Queued

Plan	Summary
2026-04-21-event-renderer.md	Cross-platform UI-agnostic `RenderedEvent` subsystem shared by Amy, Desktop, and Android; not started.
2026-08-03-poll-results-page.md	Extended NIP-88 poll results page (per-option counts + who voted for what) for Android and Desktop; also specifies four tally-correctness fixes and the missing poll-relay subscription. Proposed, not started.

Shipped

Plan	Summary
2026-09-12-audit-findings.md	Bug/performance audit of `commons` + `commonsUI` after the split: 34 verified fixes shipped, 4 deferred with rationale, 6 rejected.
2026-09-12-commons-ui-split.md	Split the Compose half of `commons` into the new `:commonsUI` module (same packages, `api(:commons)`), so `cli` no longer carries Compose/Skiko; records the classification method and follow-ups.

Archived (shipped)

Plan	Summary
archive/2026-05-04-custom-feeds-testing-sheet.md	Test sheet recording the completed custom-feeds phases (unit + manual coverage).
archive/2026-05-05-feed-builder-enhancements-plan.md	Six FeedBuilderDialog enhancements (npub decode, author search, kind filters, edit/delete, save-as-feed, exclude authors) — all landed.