mirror of https://github.com/vitorpamplona/amethyst.git synced 2026-07-30 19:46:17 +00:00

Files

T

nrobi144andClaude Opus 4.6 7ff4d8e3b7 fix(desktop): avatar ripple + P3 hardcoded colors + inline shapes

Avatar/Account switcher:
- Rewrite SidebarAccountHeader with same shape/hover as other nav items
- Entire row (avatar + display name) is clickable with rounded clip
- Inline DropdownMenu replaces overlaid AccountSwitcherDropdown
- Collapsed: compact avatar with same rounded hover treatment

P3 #004 — Hardcoded status colors:
- Add StatusGreen/StatusRed/StatusAmber to commons Colors.kt
- Replace 32 inline Color() values across 10 files with theme tokens
- Color.Red → MaterialTheme.colorScheme.error where appropriate
- Color.Green/Gray → StatusGreen/onSurfaceVariant

P3 #005 — Inline shapes:
- RoundedCornerShape(8.dp) → MaterialTheme.shapes.small (~20 files)
- RoundedCornerShape(12.dp) → MaterialTheme.shapes.medium
- RoundedCornerShape(16.dp) → MaterialTheme.shapes.large
- Pill shapes (100dp/999dp) kept as-is

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>

2026-05-29 07:02:52 +03:00

1.3 KiB

Raw Permalink Blame History

status, priority, issue_id, tags

status

priority

issue_id

Cmd+F should be context-aware: inline on feeds, full search elsewhere

Problem Statement

Cmd+F currently toggles feedSearchActiveState which only works on the Home/Feeds screen. When on Messages, Settings, Bookmarks, or other non-feed screens, Cmd+F should open the full Search column instead.

Findings

Main.kt MenuBar: Cmd+F sets feedSearchActiveState.value = !feedSearchActiveState.value
FeedScreen reads LocalFeedSearchActive.current — only works when FeedScreen is visible
On other screens (Messages, Settings, etc.), the state changes but nothing happens visually

Proposed Solutions

Option A: Check current screen type in Cmd+F handler

Read activeColumnType from deck/single-pane state
If HomeFeed/GlobalFeed/CustomFeed → toggle inline search
Otherwise → navigate to Search column

Option B: Use two shortcuts

Cmd+F → always opens inline search on feed (no-op on other screens)
Cmd+Shift+F → always opens full Search column

Acceptance Criteria

Cmd+F on Home/Feeds screen → inline search expands
Cmd+F on any other screen → opens full Search column/screen
Cmd+F on already-expanded search → collapses it

1.3 KiB Raw Permalink Blame History