From e976bf9e2e0b6c737299ff7d36aa3ac96fcab690 Mon Sep 17 00:00:00 2001
From: davotoula <david.kaspar@gmail.com>
Date: Tue, 24 Mar 2026 09:24:28 +0100
Subject: [PATCH] =?UTF-8?q?code=20review:=20-=20Removed=20redundant=20equa?=
 =?UTF-8?q?lity=20guards=20in=20SideEffect=20=E2=80=94=20MutableState=20al?=
 =?UTF-8?q?ready=20suppresses=20no-op=20writes=20for=20value=20types=20-?=
 =?UTF-8?q?=20Changed=20mutableStateOf({})=20to=20mutableStateOf(null)=20w?=
 =?UTF-8?q?ith=20explicit=20nullable=20type=20=E2=80=94=20clearer=20intent?=
 =?UTF-8?q?,=20no=20accidental=20no-op=20invocation=20-=20=20stopRecording?=
 =?UTF-8?q?()=20now=20early-returns=20with=20=3F:=20return=20when=20not=20?=
 =?UTF-8?q?recording,=20so=20the=20Toast=20only=20shows=20for=20genuinely?=
 =?UTF-8?q?=20failed=20recordings=20(too=20short)?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 .../amethyst/ui/actions/uploads/RecordAudio.kt         |  7 +++----
 .../amethyst/ui/actions/uploads/RecordVoiceButton.kt   | 10 +++-------
 2 files changed, 6 insertions(+), 11 deletions(-)

diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordAudio.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordAudio.kt
index 82888202a0..0154ca0499 100644
--- a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordAudio.kt
+++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordAudio.kt
@@ -79,7 +79,8 @@ fun RecordAudioBox(
     }
 
     fun stopRecording() {
-        val result = mediaRecorder.value?.stop()
+        val recorder = mediaRecorder.value ?: return
+        val result = recorder.stop()
         mediaRecorder.value = null
         if (result != null) {
             onRecordTaken(result)
@@ -138,9 +139,7 @@ fun RecordAudioBox(
         },
         content = { active ->
             content(active, elapsedSeconds) {
-                if (isRecording) {
-                    stopRecording()
-                }
+                stopRecording()
             }
         },
     )
diff --git a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordVoiceButton.kt b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordVoiceButton.kt
index 856e36e473..c4ae7a504f 100644
--- a/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordVoiceButton.kt
+++ b/amethyst/src/main/java/com/vitorpamplona/amethyst/ui/actions/uploads/RecordVoiceButton.kt
@@ -50,7 +50,7 @@ fun RecordVoiceButton(
 ) {
     var isRecording by remember { mutableStateOf(false) }
     var elapsedSeconds by remember { mutableIntStateOf(0) }
-    var onStopRecording by remember { mutableStateOf({}) }
+    var onStopRecording: (() -> Unit)? by remember { mutableStateOf(null) }
 
     Column(
         verticalArrangement = Arrangement.Center,
@@ -73,12 +73,8 @@ fun RecordVoiceButton(
             maxDurationSeconds = maxDurationSeconds,
         ) { recordingState, elapsed, onStop ->
             SideEffect {
-                if (isRecording != recordingState) {
-                    isRecording = recordingState
-                }
-                if (elapsedSeconds != elapsed) {
-                    elapsedSeconds = elapsed
-                }
+                isRecording = recordingState
+                elapsedSeconds = elapsed
                 onStopRecording = onStop
             }