From 0bd97926a0e9f4ecc39e0e851c49659f7be2d4ac Mon Sep 17 00:00:00 2001 From: davotoula Date: Tue, 15 Sep 2026 17:59:21 +0200 Subject: [PATCH] test(nwc): pin that a pay_invoice refusal decrypts with its message over NIP-04 and NIP-44 MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Field report (BrollyZapper 0.1.10, 2026-08-25): QUOTA_EXCEEDED on pay_invoice rendered nothing while PAYMENT_FAILED on the same wallet rendered its text. This encrypts the wallet's exact reply bytes, signs them as the wallet, and decrypts through NostrWalletConnectResponseCache — the cache the zap path reads. Both codes come out as IErrorResponseLike with their message, over both encryption schemes. Nothing on the client path (tracker match, decrypt, parse, IErrorResponseLike render) branches on the error code, so today's tree does not reproduce the silence: the field build predates 24a8540ad9, and the loss was upstream of the handler (relay delivery) or a reply the old PayInvoiceErrorResponse check dropped. Refs: dkamy-cy6.4 --- .../NwcRefusalRoundTripTest.kt | 87 +++++++++++++++++++ 1 file changed, 87 insertions(+) create mode 100644 quartz/src/commonTest/kotlin/com/vitorpamplona/quartz/nip47WalletConnect/NwcRefusalRoundTripTest.kt diff --git a/quartz/src/commonTest/kotlin/com/vitorpamplona/quartz/nip47WalletConnect/NwcRefusalRoundTripTest.kt b/quartz/src/commonTest/kotlin/com/vitorpamplona/quartz/nip47WalletConnect/NwcRefusalRoundTripTest.kt new file mode 100644 index 0000000000..2fcc8d3b14 --- /dev/null +++ b/quartz/src/commonTest/kotlin/com/vitorpamplona/quartz/nip47WalletConnect/NwcRefusalRoundTripTest.kt @@ -0,0 +1,87 @@ +/* + * Copyright (c) 2025 Vitor Pamplona + * + * Permission is hereby granted, free of charge, to any person obtaining a copy of + * this software and associated documentation files (the "Software"), to deal in + * the Software without restriction, including without limitation the rights to use, + * copy, modify, merge, publish, distribute, sublicense, and/or sell copies of the + * Software, and to permit persons to whom the Software is furnished to do so, + * subject to the following conditions: + * + * The above copyright notice and this permission notice shall be included in all + * copies or substantial portions of the Software. + * + * THE SOFTWARE IS PROVIDED "AS IS", WITHOUT WARRANTY OF ANY KIND, EXPRESS OR + * IMPLIED, INCLUDING BUT NOT LIMITED TO THE WARRANTIES OF MERCHANTABILITY, FITNESS + * FOR A PARTICULAR PURPOSE AND NONINFRINGEMENT. IN NO EVENT SHALL THE AUTHORS OR + * COPYRIGHT HOLDERS BE LIABLE FOR ANY CLAIM, DAMAGES OR OTHER LIABILITY, WHETHER IN + * AN ACTION OF CONTRACT, TORT OR OTHERWISE, ARISING FROM, OUT OF OR IN CONNECTION + * WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE SOFTWARE. + */ +package com.vitorpamplona.quartz.nip47WalletConnect + +import com.vitorpamplona.quartz.nip01Core.crypto.KeyPair +import com.vitorpamplona.quartz.nip01Core.signers.NostrSignerInternal +import com.vitorpamplona.quartz.nip47WalletConnect.cache.NostrWalletConnectResponseCache +import com.vitorpamplona.quartz.nip47WalletConnect.events.LnZapPaymentRequestEvent +import com.vitorpamplona.quartz.nip47WalletConnect.events.LnZapPaymentResponseEvent +import com.vitorpamplona.quartz.nip47WalletConnect.rpc.IErrorResponseLike +import com.vitorpamplona.quartz.nip47WalletConnect.rpc.PayInvoiceMethod +import kotlinx.coroutines.test.runTest +import kotlin.test.Test +import kotlin.test.assertEquals +import kotlin.test.assertIs + +/** + * A wallet's refusal, encrypted exactly as it sent it, decrypts through the response + * cache the zap path reads into something with a message to render — whatever the error + * code, over NIP-04 and NIP-44 alike. Parsing alone is pinned in [ResponseTest]; this + * covers the wire bytes. It does not cover `LocalCache.consume` or relay delivery. + */ +class NwcRefusalRoundTripTest { + private val clientSigner = NostrSignerInternal(KeyPair()) + private val walletSigner = NostrSignerInternal(KeyPair()) + + private suspend fun assertRefusalDecryptsWithMessage( + code: String, + message: String, + ) { + val walletJson = """{"result_type":"pay_invoice","error":{"code":"$code","message":"$message"}}""" + + for (useNip44 in listOf(false, true)) { + val request = + LnZapPaymentRequestEvent.createRequest( + PayInvoiceMethod.create("lnbc50n1pjtest"), + walletSigner.pubKey, + clientSigner, + useNip44 = useNip44, + ) + + // Encrypted by hand rather than through LnZapPaymentResponseEvent.createResponse, + // which re-serializes a Response: the point is the wallet's bytes, verbatim. + val encrypted = + if (useNip44) { + walletSigner.nip44Encrypt(walletJson, clientSigner.pubKey) + } else { + walletSigner.nip04Encrypt(walletJson, clientSigner.pubKey) + } + val reply = + walletSigner.sign( + request.createdAt, + LnZapPaymentResponseEvent.KIND, + arrayOf(arrayOf("p", clientSigner.pubKey), arrayOf("e", request.id)), + encrypted, + ) + + val response = NostrWalletConnectResponseCache(clientSigner).decryptResponse(reply) + assertIs(response, "$code over ${if (useNip44) "NIP-44" else "NIP-04"}") + assertEquals(message, response.errorMessage()) + } + } + + @Test + fun quotaExceededDecryptsWithItsMessage() = runTest { assertRefusalDecryptsWithMessage("QUOTA_EXCEEDED", "this payment would exceed the connection's budget for this period") } + + @Test + fun paymentFailedDecryptsWithItsMessage() = runTest { assertRefusalDecryptsWithMessage("PAYMENT_FAILED", "NO_ROUTE: no route found") } +}